Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rg/controller: optimize the fallback mechanism of the controller #8402

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jul 16, 2024

What problem does this PR solve?

Issue Number: close #8388.

What is changed and how does it work?

This PR implements a more robust fallback method, which uses an independent default group controller for each tombstone group.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Support multiple dynamic changes:

No interruption even after the GC cleanup:

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato force-pushed the fix_GetResourceGroup branch from bf07c02 to 0252d93 Compare July 16, 2024 09:19
@JmPotato JmPotato requested review from nolouch and HuSharp July 16, 2024 09:19
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

client/resource_group/controller/controller.go Outdated Show resolved Hide resolved
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from nolouch July 16, 2024 11:16
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.21%. Comparing base (cbba49a) to head (916354f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8402      +/-   ##
==========================================
- Coverage   77.24%   77.21%   -0.04%     
==========================================
  Files         471      471              
  Lines       61700    61728      +28     
==========================================
+ Hits        47662    47664       +2     
- Misses      10463    10477      +14     
- Partials     3575     3587      +12     
Flag Coverage Δ
unittests 77.21% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 14:29:16.696312092 +0000 UTC m=+364178.687253554: ☑️ agreed by HuSharp.
  • 2024-07-17 05:29:40.970140799 +0000 UTC m=+418202.961082268: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 5ec6af4 into tikv:master Jul 17, 2024
23 of 25 checks passed
@JmPotato JmPotato deleted the fix_GetResourceGroup branch July 17, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/resource-control dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fallback to the default resource group when the specified one does not exist
3 participants