-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rg/controller: optimize the fallback mechanism of the controller #8402
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
bf07c02
to
0252d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8402 +/- ##
==========================================
- Coverage 77.24% 77.21% -0.04%
==========================================
Files 471 471
Lines 61700 61728 +28
==========================================
+ Hits 47662 47664 +2
- Misses 10463 10477 +14
- Partials 3575 3587 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #8388.
What is changed and how does it work?
Check List
Tests
Support multiple dynamic changes:
No interruption even after the GC cleanup:
Release note