-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctl: add a message if the scheduler does not exist #8503
Conversation
Signed-off-by: husharp <ihusharp@gmail.com>
Signed-off-by: husharp <ihusharp@gmail.com>
@okJiang PTAL, thx! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8503 +/- ##
==========================================
+ Coverage 77.60% 77.64% +0.03%
==========================================
Files 474 474
Lines 61852 61864 +12
==========================================
+ Hits 48003 48036 +33
+ Misses 10317 10295 -22
- Partials 3532 3533 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an issue for this pr
/hold |
Let's wait for @okJiang to approve. |
After discussing with PM. He gives suggestions for these 2 issues:
PM: The failed msg is
PM: Since add and config are two subcommands, it doesn't seem necessary to unify them, which makes sense. |
Signed-off-by: husharp <ihusharp@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
before
./pd-ctl scheduler config evict-leader-scheduler add-store 2 Failed! [404] 404 page not found
After
./pd-ctl scheduler config evict-leader-scheduler add-store 2 Failed! scheduler evict-leader-scheduler not found.
Check List
Tests
Release note