Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/tso: Create independent clients to prevent interfering with other tests. #8546

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Aug 19, 2024

What problem does this PR solve?

Issue Number: Ref #8103

What is changed and how does it work?

tests/tso: Create independent clients to prevent interfering with other tests.

Check List

Tests

  • Integration test

Release note

None.

Signed-off-by: husharp <ihusharp@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.62%. Comparing base (a766351) to head (a727a0d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8546      +/-   ##
==========================================
+ Coverage   77.56%   77.62%   +0.05%     
==========================================
  Files         474      474              
  Lines       61861    61861              
==========================================
+ Hits        47981    48017      +36     
+ Misses      10347    10304      -43     
- Partials     3533     3540       +7     
Flag Coverage Δ
unittests 77.62% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-20 03:12:12.261088166 +0000 UTC m=+235127.395538280: ☑️ agreed by lhy1024.
  • 2024-08-20 07:36:00.530847971 +0000 UTC m=+250955.665298092: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 6bf980d into tikv:master Aug 20, 2024
20 of 21 checks passed
@HuSharp HuSharp deleted the make_tso_test_stable branch August 20, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants