tests: make TestAllocIDAfterLeaderChange more stable #8558
Conversation
Signed-off-by: husharp <ihusharp@gmail.com>
ti-chi-bot
bot
added
release-note-none
dco-signoff: yes
size/XS
| @@ -106,6 +106,7 @@ func (suite *serverTestSuite) TestAllocIDAfterLeaderChange() { | |||
| pd2, err := suite.cluster.Join(suite.ctx) | |||
| re.NoError(err) | |||
| err = pd2.Run() | |||
| re.NotEmpty(suite.cluster.WaitLeader()) | |||
There was a problem hiding this comment.
There are still some cases that are not judged empty, do we need also modify them or add comments?
There was a problem hiding this comment.
Added more waiting leaders for tests related to joining situation
Signed-off-by: husharp <ihusharp@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8558 +/- ##
==========================================
+ Coverage 77.56% 77.58% +0.02%
==========================================
Files 474 474
Lines 61875 61877 +2
==========================================
+ Hits 47994 48009 +15
+ Misses 10344 10334 -10
+ Partials 3537 3534 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #8557
What is changed and how does it work?
Check List
Tests
Release note