Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: support set background resource limit #8617

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Sep 11, 2024

What problem does this PR solve?

Issue Number: Close #8616

What is changed and how does it work?

update kvproto to include pingcap/kvproto#1264 to support set background task resource limit

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None

Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2024
@glorv
Copy link
Contributor Author

glorv commented Sep 11, 2024

/cc @nolouch @HuSharp

@ti-chi-bot ti-chi-bot bot requested review from HuSharp and nolouch September 11, 2024 09:19
Signed-off-by: glorv <glorvs@163.com>
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.59%. Comparing base (e9714b6) to head (0570784).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8617      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.01%     
==========================================
  Files         474      474              
  Lines       61893    61893              
==========================================
- Hits        48029    48028       -1     
- Misses      10320    10325       +5     
+ Partials     3544     3540       -4     
Flag Coverage Δ
unittests 77.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-12 07:14:14.335585328 +0000 UTC m=+513324.076009268: ☑️ agreed by nolouch.
  • 2024-09-12 07:15:58.370165111 +0000 UTC m=+513428.110589052: ☑️ agreed by HuSharp.

@glorv
Copy link
Contributor Author

glorv commented Sep 12, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0ca83cf into tikv:master Sep 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource_manager: support background reosurce limit
3 participants