use globally shared pipe to validate memory #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
force-pushed
the
fix-197
branch
11 times, most recently
from
1838bb4 to
819d6cc
Compare
sticnarf
reviewed
Feb 16, 2023
Connor1996
reviewed
Feb 16, 2023
sticnarf
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
LGTM.
SeqCst is probably too strong here, but I think it's not a big problem. And as @Connor1996 requested, you can add some comments about how validation works.
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Merged
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #197
The pipes can be shared across the threads, because the signal only hits one thread at a time. I'm not sure why I used the
thread_localin the previous commit 😢 .