Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for aarch64-linux-android #202

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix build for aarch64-linux-android #202

merged 1 commit into from
Mar 22, 2023

Conversation

flxo
Copy link
Contributor

@flxo flxo commented Feb 27, 2023

Enable building pprof for target_os = android.

@YangKeao YangKeao self-requested a review March 1, 2023 08:31
@YangKeao
Copy link
Member

YangKeao commented Mar 1, 2023

Do you have a demo program to run pprof-rs on Android? It sounds really interesting.

@flxo flxo marked this pull request as ready for review March 6, 2023 06:37
@flxo
Copy link
Contributor Author

flxo commented Mar 8, 2023

Do you have a demo program to run pprof-rs on Android? It sounds really interesting.

I used the examples for a quick check. Looks like it works as expected. Not a bit surprise since google ships simpleperf for years which does basically the same.

@YangKeao
Copy link
Member

Could you rebase on the master? I believe the CI failing has been fixed on the latest master 🤔

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Enable building pprof for target_os = `android`.

Signed-off-by: Felix Obenhuber <felix.obenhuber@esrlabs.com>
@YangKeao YangKeao merged commit 2ed44e0 into tikv:master Mar 22, 2023
@YangKeao
Copy link
Member

Thanks again for your contribution. I'll schedule the version bump tonight (Mar 22. 20:00, UTC+8)

@flxo
Copy link
Contributor Author

flxo commented Mar 22, 2023

Thanks @YangKeao Any change that we add aarch64-linux-android in the GH actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants