Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to criterion 0.5 #212

Merged
merged 1 commit into from
Jul 3, 2023
Merged

update to criterion 0.5 #212

merged 1 commit into from
Jul 3, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented May 31, 2023 •
edited
Loading

I created a issue here, to avoid such unnecessary changes in the future
bheisler/criterion.rs#688

YangKeao
YangKeao approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

Thanks for your contribution. Please Sign-Off the commit (through git commit --amend -s) to pass DCO testing 🍻 .

@PSeitz
update to criterion 0.5
53af24b 
Signed-off-by: Pascal Seitz <pascal.seitz@gmail.com>
@PSeitz
Copy link
Contributor Author

PSeitz commented Jun 1, 2023

@YangKeao I signed off

@sd2k sd2k mentioned this pull request Jun 5, 2023
Closed
@mattsse
Copy link

mattsse commented Jul 2, 2023

friendly bump on this :)

@YangKeao YangKeao merged commit 234dc63 into tikv:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PSeitz @YangKeao @mattsse @aminya