-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asynchronously incrementally sync files to disk while they are being written #348
Comments
A similar issue: GreptimeTeam/greptimedb#3085 |
THx for your advices. This problems might not be similar to yours. And we've met this problem on Cloud Env when rewriting and fixed it in #347, by introducing FYI, u can check whether there exists similar syncing problems when rewriting raft logs. And if does, u can check the latest version as your choice. |
Do you have any plan to release a new version? |
/cc @overvenus @tabokie PTAL, thx. We'll do it recently. Before that, u can update your dependency of |
The idea is borrowed from RocksDB
bytes_per_sync
. It usessync_file_range
1 that allows asynchronously incrementally sync files to disk while they are being written.It smoothes out write I/Os over time and reduce
fdatasync
latency spike as we saw in #346 (comment) .Note: The feature proposed here is different from the deprecated
bytes_per_sync
feature which sync file synchronously.Footnotes
https://man7.org/linux/man-pages/man2/sync_file_range.2.html ↩
The text was updated successfully, but these errors were encountered: