-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options to enable log recycle and periodical fsync #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
docs-not-required
This change does not impact docs.
label
Jan 7, 2024
v0y4g3r
added
A-storage
Involves code in storage engines
docs-not-required
This change does not impact docs.
C-performance
Category Performance
labels
Jan 7, 2024
github-actions
bot
removed
the
docs-not-required
This change does not impact docs.
label
Jan 7, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
- Coverage 85.59% 85.10% -0.49%
==========================================
Files 815 815
Lines 133334 133348 +14
==========================================
- Hits 114123 113488 -635
- Misses 19211 19860 +649 |
github-actions
bot
removed
the
docs-not-required
This change does not impact docs.
label
Jan 8, 2024
github-actions
bot
added
docs-required
This change requires docs update.
docs-not-required
This change does not impact docs.
and removed
docs-required
This change requires docs update.
labels
Jan 8, 2024
evenyag
reviewed
Jan 8, 2024
evenyag
approved these changes
Jan 9, 2024
fengjiachun
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there is some conflicts
v0y4g3r
force-pushed
the
feat/periodical-wal-sync
branch
from
January 9, 2024 06:29
3ed9890
to
f499125
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-storage
Involves code in storage engines
C-performance
Category Performance
docs-not-required
This change does not impact docs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds config to enable log recycle/prefill and periodical log fsync to smooth IO utilization. This change helps both local fs and S3 mode.
Rows written per second change
enable_log_recycle
: trueprefill_log_files
: falsesync_period
: 1000msLocal FS mode
Before:
After:
S3 mode (tested on MinIO)
Before:
After:
Checklist
Refer to a related PR or issue link (optional)
Fixes #3085