Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate fallocate failure and print IO error in debug form (#225) #226

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jun 21, 2022

Cherry-pick #225 to 0.2.x.

Signed-off-by: tabokie xy.tao@outlook.com

* tolerate fallocate failure and print IO error in debug form

Signed-off-by: tabokie <xy.tao@outlook.com>

* update CHANGELOG.md

Signed-off-by: tabokie <xy.tao@outlook.com>

* only tolerate e=95

Signed-off-by: tabokie <xy.tao@outlook.com>

* still tolerate unconditionally

Signed-off-by: tabokie <xy.tao@outlook.com>

* update doc

Signed-off-by: tabokie <xy.tao@outlook.com>

* add a failpoint test

Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie requested a review from Connor1996 June 21, 2022 05:09
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #226 (6022735) into 0.2.x (e15b9ec) will decrease coverage by 0.06%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##            0.2.x     #226      +/-   ##
==========================================
- Coverage   97.31%   97.25%   -0.07%     
==========================================
  Files          29       29              
  Lines        8803     8826      +23     
==========================================
+ Hits         8567     8584      +17     
- Misses        236      242       +6     
Impacted Files Coverage Δ
src/errors.rs 100.00% <ø> (ø)
src/env/default.rs 92.00% <57.14%> (-1.83%) ⬇️
src/file_pipe_log/log_file.rs 100.00% <100.00%> (ø)
tests/failpoints/test_io_error.rs 100.00% <100.00%> (ø)
src/log_batch.rs 97.34% <0.00%> (-0.45%) ⬇️
src/pipe_log.rs 94.11% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15b9ec...6022735. Read the comment docs.

@tabokie tabokie merged commit c0df442 into tikv:0.2.x Jun 22, 2022
@tabokie tabokie deleted the cp-fallocate branch June 22, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant