Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe: reseek after write failure #245

Merged
merged 2 commits into from
Jul 15, 2022
Merged

pipe: reseek after write failure #245

merged 2 commits into from
Jul 15, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jul 15, 2022

Close #243

Signed-off-by: tabokie xy.tao@outlook.com

Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
Copy link
Member Author

tabokie commented Jul 15, 2022

/cc @LykxSassinator

Signed-off-by: tabokie <xy.tao@outlook.com>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #245 (ae096da) into master (f3c268b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   96.69%   96.71%   +0.02%     
==========================================
  Files          30       30              
  Lines        9517     9577      +60     
==========================================
+ Hits         9202     9262      +60     
  Misses        315      315              
Impacted Files Coverage Δ
src/env/default.rs 92.26% <100.00%> (+0.13%) ⬆️
src/file_pipe_log/log_file.rs 99.31% <100.00%> (+0.03%) ⬆️
tests/failpoints/test_io_error.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c268b...ae096da. Read the comment docs.

Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie tabokie merged commit 764ac71 into tikv:master Jul 15, 2022
@tabokie tabokie deleted the fix-243 branch July 15, 2022 10:20
tabokie added a commit to tabokie/raft-engine that referenced this pull request Jul 18, 2022
* reseek after write failure

Signed-off-by: tabokie <xy.tao@outlook.com>

* update changelog

Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie added a commit that referenced this pull request Jul 18, 2022
* pipe: reseek after write failure (#245)

* reseek after write failure

Signed-off-by: tabokie <xy.tao@outlook.com>

* update changelog

Signed-off-by: tabokie <xy.tao@outlook.com>

* fix changelog

Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interrupted write causes corruption
3 participants