Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default enable log recycling #265

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

LykxSassinator
Copy link
Contributor

Description

Default enable log recycling. Close #263.

Signed-off-by: Lucasliang nkcs_lykx@hotmail.com

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 97.71% // Head: 97.65% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (72b77d9) compared to base (62a69a8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   97.71%   97.65%   -0.07%     
==========================================
  Files          30       30              
  Lines       10644    10645       +1     
==========================================
- Hits        10401    10395       -6     
- Misses        243      250       +7     
Impacted Files Coverage Δ
src/config.rs 96.68% <100.00%> (-0.67%) ⬇️
tests/failpoints/test_engine.rs 99.84% <100.00%> (+<0.01%) ⬆️
src/consistency.rs 91.11% <0.00%> (-2.23%) ⬇️
src/env/default.rs 92.39% <0.00%> (-1.64%) ⬇️
src/log_batch.rs 97.97% <0.00%> (-0.41%) ⬇️
src/purge.rs 97.45% <0.00%> (-0.29%) ⬇️
src/env/mod.rs 100.00% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tabokie tabokie changed the title [Close #263]Default enable log recycling. Default enable log recycling Aug 30, 2022
Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog under "Behavior changes".

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
@tabokie tabokie merged commit 9751c6d into tikv:master Aug 31, 2022
@LykxSassinator LykxSassinator deleted the default-enable-recycle branch September 29, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default enable log recycling.
2 participants