fix panic when reusing a was-empty batch #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Codecov ReportBase: 97.74% // Head: 97.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 97.74% 97.67% -0.08%
==========================================
Files 30 30
Lines 10633 10655 +22
==========================================
+ Hits 10393 10407 +14
- Misses 240 248 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/cc @LykxSassinator |
src/engine.rs
Outdated
| let start = Instant::now(); | ||
| let len = log_batch.finish_populate(self.cfg.batch_compression_threshold.0 as usize)?; | ||
| debug_assert!(!log_batch.is_empty()); |
There was a problem hiding this comment.
Do it before finish_populate or remove it. The first validation log_batch.is_empty() has guaranteed that log_batch.is_empty() == false.
tabokie
commented
Sep 6, 2022
Signed-off-by: Xinye Tao <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #266
An empty batch went through
finish_populatebut notdrain(in memtable apply block). This will break internal state machine and panic.