-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement committed entries pagination #440
Conversation
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Why not set it by |
Using an |
How about adding an API to mutate the configuration instead of adding a new parameter? |
Signed-off-by: qupeng <qupeng@pingcap.com>
I recall there is already a PR implementing the feature #356, can you update the PR and pick to master? |
Signed-off-by: qupeng <qupeng@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_commit_pagination_after_restart should also be ported.
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng qupeng@pingcap.com
This is a re-implement for #356, except such things:
max_committed_size_per_ready
isn't pushed intoRaftLog
Ready
andLightReady