-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support pre-generate bindings for aarch64 #435
Conversation
Signed-off-by: glorv <glorvs@163.com>
Sorry, we have no plan to pre-generate bindings for aarch64. It's fine for generating it when building. |
From v4.0, we need to support aarch64 platform, so it's make sense to use pre-generated bindings to make compilation easily. In cenos7 with aarch64 cpu, the raw bind-gen need newer version of clang (>6) which isn't provided in most case. So I think we should support this feature. |
Signed-off-by: glorv <glorvs@163.com>
…contain enough components for aarch64 Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yiwu-arbug PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* add pre generated binding for aarch64 Signed-off-by: glorv <glorvs@163.com>
in #402 we already support pre-generate bindings for x64_64, this pr add support for aarch64
Signed-off-by: glorv glorvs@163.com