Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config: auto set default configurations when configurations are not valid. #12771

Closed
3pointer opened this issue Jun 6, 2022 · 0 comments · Fixed by #12767
Closed

Config: auto set default configurations when configurations are not valid. #12771

3pointer opened this issue Jun 6, 2022 · 0 comments · Fixed by #12767
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@3pointer
Copy link
Contributor

3pointer commented Jun 6, 2022

Feature Request

Is your feature request related to a problem? Please describe:

Some components like Backup/Import/CDC should not refuse to start when the config is invalid and has the default value.

Describe the feature you'd like:

Auto set invalid configurations.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@3pointer 3pointer added the type/enhancement The issue or PR belongs to an enhancement. label Jun 6, 2022
@3pointer 3pointer mentioned this issue Jun 6, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jun 9, 2022
@3pointer @zhangjinpeng87 @ti-chi-bot
config: output warn log when some components config invalid (#12767)
fd7b4ad 
close #12771

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
BornChanger pushed a commit to BornChanger/tikv that referenced this issue Jun 10, 2022
@3pointer @zhangjinpeng87
@ti-chi-bot @BornChanger
config: output warn log when some components config invalid (tikv#12767)
e7fc49c 
close tikv#12771

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
BornChanger pushed a commit to BornChanger/tikv that referenced this issue Jun 10, 2022
@3pointer @zhangjinpeng87
@ti-chi-bot @BornChanger
config: output warn log when some components config invalid (tikv#12767)
7d1d3c2 
close tikv#12771

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: output warn log when some components config invalid 3pointer/tikv
1 participant
@3pointer