Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasional memory leak in std mpsc channels and crossbeam channels #17178

Open
1 of 2 tasks
Tracked by #16375
overvenus opened this issue Jun 24, 2024 · 0 comments · May be fixed by #17605
Open
1 of 2 tasks
Tracked by #16375

Occasional memory leak in std mpsc channels and crossbeam channels #17178

overvenus opened this issue Jun 24, 2024 · 0 comments · May be fixed by #17605
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/leak severity/major type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

overvenus commented Jun 24, 2024 •
edited
Loading

Bug Report

This issue can occur if a sender installs the first block right after all receivers have disconnected and checked for any existing messages, causing a memory leak.

See upstream issue report: rust-lang/rust#121582

To fix this we need to

What version of TiKV are you using?

nightly, 2024-6-23
@overvenus overvenus added the type/bug The issue is confirmed as a bug. label Jun 24, 2024
@overvenus overvenus mentioned this issue Jun 24, 2024
Merged
1 task
@overvenus overvenus added severity/minor affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jun 24, 2024
@overvenus overvenus mentioned this issue Jun 24, 2024
Open
17 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 24, 2024
@overvenus
*: upgrade crossbeam-channel (#17179)
da81e6e 
ref #17178

Fix memory leak in crossbeam-channel's unbounded channel.

Signed-off-by: Neil Shen <overvenus@gmail.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this issue Jun 27, 2024
@overvenus @3AceShowHand
*: upgrade crossbeam-channel (tikv#17179)
0331b3a 
ref tikv#17178

Fix memory leak in crossbeam-channel's unbounded channel.

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
@overvenus overvenus linked a pull request Oct 9, 2024 that will close this issue
Open
9 tasks
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. impact/leak severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Update rust toolchain to nightly-2024-08-29 to use faster linker Connor1996/tikv
2 participants
@overvenus @jebter