Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: tolerate large response (#10971) #10992

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 26, 2021

cherry-pick #10971 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/10992

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tikv.git pr/10992:release-5.1-d9f7368ae108

What problem does this PR solve?

Issue Number: close #9012

What's Changed:

gRPC can't handle messages larger than 4GiB. This PR solves the issue by
checking response's binary length during serializing. Before the change,
TiKV will either coredump in grpc or panic in protobuf, after the
change, it will print a log in the TiKV side and call will be cancel in
the client side.

[2021/09/22 17:00:15.211 +08:00] [INFO] [kv.rs:1011] ["kv rpc failed"] [err="Codec(IoError(Custom { kind: Other, error: \"given slice is too small to serialize the message\" }))"] [request=batch_commands]

Check List

Tests

  • Manual test
    Configure TiKV region size to 1TiB and load more than 10GiB data into TiKV. Run a full table scan.

Release note

Fix panic in coprocessor when response size exceeds 4GiB

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2021
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels Sep 26, 2021
@ti-srebot ti-srebot added this to the v5.1.2 milestone Sep 26, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2021
@BusyJay
Copy link
Member

BusyJay commented Sep 27, 2021

Close as it rarely happens and will be fixed in v5.2.2. Will reopen if anyone desire to land it on this release.

@BusyJay BusyJay closed this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants