Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_memory_engine: fix the assert panic caused by gc #17682

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Oct 18, 2024

What is changed and how it works?

Issue Number: Close #17667

What's Changed:

Fix the bug that when region is split before gc task start, the gc task
only mark in_gc state for the region with the same id, but will unset
it for all the regions within the given range.

NOTE: for implementation simplicity, after this change, in the condition,
the gc will only run on the region with the same id, other regions in
the same range will skip this GC round.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 18, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-triage-completed labels Oct 18, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 18, 2024
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: overvenus, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SpadeA-Tang,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-18 07:30:27.316469006 +0000 UTC m=+601824.465378836: ☑️ agreed by SpadeA-Tang.
  • 2024-10-18 12:34:42.01256851 +0000 UTC m=+8882.709359112: ☑️ agreed by overvenus.

@ti-chi-bot ti-chi-bot bot merged commit 51715fa into tikv:master Oct 18, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Oct 18, 2024
@glorv glorv deleted the fix-gc branch October 23, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In-memory engine: in gc assertion failed
3 participants