import: use memory to cache split sst instead of disk file #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Apr 25, 2019
kennytm
reviewed
Apr 25, 2019
Signed-off-by: Lonng <chris@lonng.org>
|
@zhangjinpeng1987 @kennytm PTAL again. |
kennytm
approved these changes
Apr 25, 2019
overvenus
approved these changes
Apr 25, 2019
lonng
added a commit
that referenced
this pull request
Apr 26, 2019
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Apr 26, 2019
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Apr 26, 2019
Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
added a commit
to kennytm/tikv
that referenced
this pull request
Apr 26, 2019
Signed-off-by: kennytm <kennytm@gmail.com>
jswh
pushed a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
Signed-off-by: Lonng <chris@lonng.org>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Lonng <chris@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng chris@lonng.org
What have you changed? (mandatory)
Fix importer BUG
The importer will return success even though some ranges failure in the current version.
Use memory to cache split SST file instead of disk file to reduce disk IO.
We need to split
Engine Fileto small SST files to fit the region size. There are some steps required in the current implementation, which heavily depend on disk.