-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raft client: make grpc message size limit configurable (#7816) #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
/run-all-tests |
sre-bot
added
component/server
Component: Server
type/cherry-pick
Type: PR - Cherry pick
labels
May 13, 2020
hunterlxt
approved these changes
May 13, 2020
MyonKeminta
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 13, 2020
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
1 similar comment
/run-all-tests |
@sre-bot merge failed. |
/run-all-tests |
1 similar comment
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
Component: Server
status/can-merge
Indicates a PR has been approved by a committer.
type/cherry-pick
Type: PR - Cherry pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #7816 to release-4.0
Signed-off-by: qupeng qupeng@pingcap.com
What problem does this PR solve?
Too large raft entry will cause raft client send failure.
Problem Summary:
What is changed and how it works?
Make grpc message size configurable in raft client.
Related changes
Check List
Tests
Side effects
Release note