server: allow wildcard address for advertise-status-addr to keep compatible with tidb-operator (#8016) #8046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/server
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
force-pushed
the
release-4.0-af7891288e5f
branch
from
ee3b3b0 to
21a31be
Compare
|
/run-all-tests |
overvenus
approved these changes
Jun 5, 2020
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
rleungx
approved these changes
Jun 5, 2020
|
/run-all-tests |
|
/run-unit-tests |
overvenus
approved these changes
Jun 5, 2020
|
/merge |
|
Sorry @overvenus, you don't have permission to trigger auto merge event on this branch. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #7944 #8016 to release-4.0
Signed-off-by: linning linningde25@gmail.com
What problem does this PR solve?
Issue Number: close #8013
Problem Summary:
In tidb-operator-1.1,
0.0.0.0will be used forstatus-addrandadvertise-status-addrwill fallback tostatus-addrbecause not specified, in such caseinvalid advertise-status-addrerror will return when start tikv, because in #7944 we always checkadvertise-status-addris not a wildcard address.What is changed and how it works?
Proposal: #7920
What's Changed:
Check
advertise-status-addris not a wildcard address only if it is specified.Release note