-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: add server info metrics for DBasS (#9582) #9591
server: add server info metrics for DBasS (#9582) #9591
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@iosmanthus please accept the invitation then you can push to the cherry-pick pull requests. |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
/lgtm |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@zhongzc: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 36c5c24
|
/merge |
@NingLin-P: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@NingLin-P: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #9582 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tikv repo: git pr https://github.com/tikv/tikv/pull/9591
After apply modifications, you can push your change to this PR via:
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
This pull request adds server info metrics via a
GaugeVec
in format:(version, githash) -> startup_ts
.Problem Summary:
Related changes
Check List
Tests
Side effects
Release note