Revert wait for flush before GC #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Wu <yiwu@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 86.93% 86.98% +0.04%
==========================================
Files 44 44
Lines 3254 3250 -4
==========================================
- Hits 2829 2827 -2
+ Misses 425 423 -2 |
|
|
|
/run-all-tests |
|
/cherry-picker |
|
/cherry-pick |
|
/run-cherry-picker |
|
cherry pick to tikv-3.0 in PR #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Revert temp fix introduced in #96 which wait for memtable flush before a GC job, since potentially that can make GC starve if there are ongoing flush. We can revert the fix in favor of the fix from rocksdb upstream: tikv/rocksdb#127
Test Plan:
Make sure TitanDBTest::GCBeforeFlushCommit test still passes.
Signed-off-by: Yi Wu yiwu@pingcap.com