Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give more RAM to the build-linux job #3726

Merged
merged 1 commit into from
Aug 25, 2020
Merged

give more RAM to the build-linux job #3726

merged 1 commit into from
Aug 25, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Aug 25, 2020

Hello @landism, @maiamcc,

Please review the following commits I made in branch nicks/lint:

3fd7bfb (2020-08-25 12:59:34 -0400)
give more RAM to the build-linux job

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested review from landism and maiamcc August 25, 2020 16:59
@nicks nicks force-pushed the nicks/lint branch 2 times, most recently from 6a0d315 to 894956d Compare August 25, 2020 17:10
@nicks
Copy link
Member Author

nicks commented Aug 25, 2020

wahhhhhh

seems to be some chatter on this here, going to try upgrading golangci-lint and see if that fixes it
golangci/golangci-lint#994

@nicks
Copy link
Member Author

nicks commented Aug 25, 2020

hooray! that seems to have fixed it

@nicks nicks merged commit 933e20b into master Aug 25, 2020
@nicks nicks deleted the nicks/lint branch August 25, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant