tiltfile: add stdin_mode='pty' to local_resource() #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
commented
May 24, 2024
| @@ -10,3 +17,275 @@ test("test", "echo hi") | |||
| `) | |||
| f.loadAssertWarnings(testDeprecationMsg) | |||
| } | |||
|
|
|||
| func TestLocalResourceOnlyUpdateCmd(t *testing.T) { | |||
There was a problem hiding this comment.
this is just moving code around
Allows users to attach a pty, for interactive commands that try to grab the "main" tty fixes #6378 Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
changed the title
nicks
added a commit
that referenced
this pull request
May 31, 2024
This reverts commit 20ab76b. Signed-off-by: Nick Santos <nick.santos@docker.com>
nicks
added a commit
that referenced
this pull request
May 31, 2024
* Revert "tiltfile: add stdin_mode='pty' to local_resouce() (#6382)" This reverts commit 20ab76b. Signed-off-by: Nick Santos <nick.santos@docker.com> * Revert "cmd: add the ability to attach a pty to a local command (#6379)" This reverts commit 69a74bb. Signed-off-by: Nick Santos <nick.santos@docker.com> --------- Signed-off-by: Nick Santos <nick.santos@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to attach a pty,
for interactive commands that try
to grab the "main" tty
fixes #6378
Signed-off-by: Nick Santos nick.santos@docker.com