Feature: support for behavior mods #659

rfortier · 2024-04-25T21:08:20Z

Behavior mods such as those generated by Nemesis or Pandora.

Important note: this PR supports conditional compilation, which is currently set to off in the last commit. This was done to enable the code to merge without risking the imminent release. If the conditional compile is switched on, the support will be enabled in the clients and those clients should be able to use the same servers as clients without the support.

Goals

Not risk the release.
Enable compilation of a "pre-release" or test version that could be compatible with the public game servers.

Prerequisites

Previously, PR Remove limit to BehaviorVars on the wire. #658 was a prerequisite. Cosi asked me to merge that branch, so this is no longer true.

Testing

Four combinations were tested to ensure the PR is safe:

Compiled off, no mods: animations sync as expected.
Compiled off, with behavior mods: behaviors not synced, characters skating, as expected.
Compiled on, no mods: animations sync as expected.
Compiled on, with behavior mods: behaviors sync for the mods supported in the PR. Support for additional simple mods that just need an added variable or two synced can be added by dropping the definitions into the SkyrimTogetherRebornBehaviors directory.

Theory of Operation (how it works)

It's a big PR in line count, but much of that is machine-translated code. The major topics to cover are:

Directory layout, source directories and installation directories.
How the mod accomplishes its goals of enabling simple animations (no complex event management or scripting) generated by Nemesis or Pandora to sync.
Approaches to enable STR devs and modders, even end users to make behavior changes without stepping on each other.
Support for syncing additional behavior variables (in particular, more than 64 boolean variables, of which the STR code is already using 62). Note this requires a protocol change between the server and clients, so this code always compiles, while the remainder is conditionally compiled. This approach simultaneously supports two goals: the STR team can release without the mod support for lowest risk, but a version not supported by the STR team can also be compiled, and use the same servers.

Directory Layout / Changes

Source Directories

One source directory is added to the source tree at client\ModCompat. The changes support both Skyrim and Fallout4.
One file, an encumbrance, is added at \Libraries\magic_enum.hpp. This enables translating enum names to their string form, despite C++ not supporting reflection (yet). It is governed by the MIT license.
A directory tree is added to \Gamefiles\Skyrim\SkyrimTogetherRebornBehaviors. The files in this directory enable the STR mod to sync additional behavior/animation variables if a mod requires it. Any variables named in the tree are merged with the base variables the STR dev team defines. Additional files define the original STR hash of behavior variables, and a signature, a unique list of behavior variables that must exist (or must not exist) to uniquely identify an Actor.

Installation Directories

The source directory \Gamefiles\Skyrim\SkyrimTogetherRebornBehaviors must be installed alongside the SkyrimTogetherReborn directory by any FOMOD or 7z installer. It is deliberately outside the SkyrimTogetherReborn directory so 3rd party tinkering is outside of the game directory.

Theory of Operations

In a sentence, the mod works by detecting AnimationGraphDescriptor hashes that don't exist in base STR, seeing if the Actor's animation variables match a signature in the SkyrimTogetherRebornBehaviors directory, and if so, merge the STR variables with the ...Behaviors directory variables (if any, it might just be the hash was changed), and generates a new AnimationGraphDescriptor with the new hash.

The interception requires a few lines of code in References.cpp to intercept where animation variables are prepared for serialization and deserialization. They call out to BehaviorVar.cpp:BehaviorVar::Patch() when the AnimationGraphDescriptor lookup-by-hash fails.

::Patch can fail and return NULL again. This is normal; it happens when STR doesn't need to sync behaviors, syncing position and velocity is enough, so there is no AnimationGraphDescriptor at all for that creature. Wisps are an example.

If a hash lookup fails, it is added to a failed list and ignored for 10m. This because searching for a signature is semi-expensive, but more because it generates a ton of logs that aren't useful which is the real cost. 10m is long enough for most encounters to end, but short enough to try again if dynamic behavior modification is ever properly supported.

Intricacies of Merging Behavior Var Lists

Nemesis doesn't just add more behaviors to the end of the list; it rearranges the list. That's unfortunate, and it is why humans skate if just Nemesis is installed without adding any more variables to be synced; The rearranged list has a different hash.

To accomplish a merge, these operations occur:

We must be able to translate the base STR AnimationGraphDescriptors back to their string form. This is done at authoring time by running a script that translates the AnimationGraphDescriptor* files to a form that magic_enum can use to generate the string form of each enum, for everything in the Skyrim and Fallout4 directories. Currently, the output files are checked into Git. It would be better to get the xmake dependencies right, but I'll need some advice for that. And it can wait until after release.
At game startup time, the SkyrimTogetherRebornBehaviors directory is scanned. Each subdir is expected to have a *hash.txt file with the original STR base game hash, and a *sig.txt file that contains a list of behavior variables that must and must not exist to uniquely identify the Actor. Additional *bool.txt, *int.txt, and *float.txt files name any additional variables that must be synced. Each mod author can have their own files with a unique prefix, they are all merged and stored in a list of BehaviorVar::Replacer objects.
At run time, the modded behavior is matched to a Replacer via the unique signature.
The Replacer identifies the matching STR base game AnimationGraphDescriptor, which is translated back to strings which are stored in a ::Set for each of bool, int and floats.
Added variables (if any) found in the BehaviorVar::Replacer built from the SkyrimTogetherRebornBehaviors tree are merged (uniquely, because of the way ::Sets work).
The sets are translated back to an enum form to construct a new AnimationGraphDescriptor.
That descriptor is added to the game data structures in AnimationGraphDescriptorManager::Register

From that point forward, the new hash will be successfully found by the STR base-game logic.

There are a few details that added some complexity. In particular, there are misspellings of variable names even in vanilla Skyrim, usually incorrect case like speed when the correct variable is Speed; that happens with a particular Winterhold guard, for example. Having no way to know if Skyrim ever uses any variables only distinguished by capitalization, the code tries a few common variants if a lookup fails and generally will correct the problem.

Decoupling STR dev team and Modders

All this logic to match and merge is to ensure the STR dev team and modders can make changes independently without interfering with each other.

Support for Syncing Additional Behavior Variables

All of the above support will ensure animation sync if Nemesis/Pandora are used, and if no new variables need to be synced will even be compatible with the same servers used by clients without this animation support.

But to also support mods that do need to sync additional variables, such as the popular True Directional Movement, this mod needs support for syncing more variables. In particular more Boolean variables, STR base uses 62 out of a limit of 64. The limit is baked into protocol between the clients and server, so lifting the limit creates a compatibility problem.

This PR includes a merge of branch feat-unlimited-behavior-vars, which always compiles once this PR is merged to ensure versions compiled with behavior mod support will still be able to use the public servers of the same version.

Rather than simply turning the boolean long long in the code into an array, this code changes the definition AnimationVariables::Booleans from a uint64_t to a TiltedPhoques::Vector< bool >. This compiles into an array of bits with the current tech stack (this isn't guaranteed by the C++ standard, but is the norm).

This design choice was made because:

It actually takes 1 byte less on the wire than the than the approach of just adding another uint64_t in the "large" case of sending humanoids.
It takes less space on the wire than the former protocol for most creatures that don't sync very many variables.
Consistent code, everything is a Vector now.

rfortier · 2024-04-25T21:16:43Z

Some more info for people interested in testing this, but not wanting to bother with compilation.

Please report issues here on github, not to the STR dev team. Or find Ujave on the STR Discord.

I have compiled up two versions of this mod and released it on my github; a version with the compilation flag turned on, and a version with it compiled off for testing that it is safe. There's a FOMOD installer provided so anyone can try them. You can find that here.

There's not a lot of documentation yet about how to support additional mods, but @MostExcellent or I can help.

rfortier · 2024-04-28T22:13:53Z

As requested, I merged the content of PR #658 into this PR.

Support for behavior mods is compiled off by default.
The former content of PR #658 always compiles.

I'll close PR #658 now.

RobbeBryssinck · 2024-05-05T14:01:59Z

What's missing from this PR is a general overview of the PR's contents and how you've solved the problem at hand. Currently, I'd have to read the code to do that, which is a bit much given the size of the PR.

RobbeBryssinck · 2024-05-05T14:14:01Z

Code/client/ModCompat/magic_enum.hpp

This should be a library (in the Libraries folder).

RobbeBryssinck: What's missing from this PR is a general overview of the PR's contents and how you've solved the problem at hand. Currently, I'd have to read the code to do that, which is a bit much given the size of the PR.

I'll do that today. A Theory of Operation type overview, right? It will be a couple of pages or so, in an edited PR description. Most of what's needed is in the code comments, I'll just hoist them and format.

RobbeBryssinck: This [magic_enum.hpp] should be a library (in the Libraries folder).

I'll move it. The original thought was to keep it self-contained, but if it's going to be merged I understand it should be where it belongs.

Yeah just a conceptual overview of how the new system works and how it compares to the old system would be great.

Requested changes are all in. I think this thread can close.

As for concepts, it is additional logic added to the "old" system, which is all still there. So, it's better thought of as an enhancement vs. a replacement.

Well, the Unlimited part is a partial replacement.

rfortier · 2024-05-20T18:36:05Z

Rebased to /master for release.

rfortier · 2024-09-30T23:58:08Z

Updated branch to the latest /dev.

It currently compiles with MODDED_BEHAVIOR_COMPATIBILITY undefined. So only Unlimited Vars is compiled, making a standard build server-compatible with a modded animation build.

Revert the last commit to build an animation build.

Force67 · 2024-10-01T06:05:58Z

Code/client/ModCompat/BehaviorVarsMap.h

Spacing, also we do not use std::map, use the tiltedcore map, as std::map is extremely slow.

Commit 2d989d9 addresses most comments, other than clang-format will be an isolated commit to follow. Pushing this now to check CI (formatting shouldn't break CI) and check a few things.

Common Fixes:

Fixed all gaps in naming conventions; biggest one missing that FunctionsWereCapitalized().

Replaced all std:: with TiltedPhoques:: functions when possible. Sometimes TP didn't have the function (sorted sets), and sometimes conversions were broken with no workaround.

Final commit will enable the conditionally compiled code, as that seems to be the consensus.

Note enabling the code introduces a README-ANIMATION-MODS that will need review. See it in commit 11dc8bc

There were a few call-by-values that were fixed to call-by-reference to avoid copies.

Force67 · 2024-10-01T06:06:45Z

Code/client/ModCompat/BehaviorVarsMap.cpp

+
+uint32_t BehaviorVarsMap::find(const uint64_t acKey, const std::string acName)
+{
+    auto map = m_map.find(acKey);


a better variable name would be nice + spacing everywhere is off (empty lines)

We have a clang format you can execute over the codebase

Commit 2d989d9

A better name than acKey is hard, as the base STR code is using m_key. But, took a crack.

Force67 · 2024-10-01T06:07:16Z

Code/client/ModCompat/BehaviorVar.h

+    std::vector<uint64_t> signatureMatches(const uint64_t acHash, const std::string acSignature) const;
+
+    std::vector<Replacer> behaviorPool; // Pool for loaded behaviours
+    std::map<uint64_t, std::chrono::steady_clock::time_point> failedBehaviors;


Tiltedcore map

Commit 2d989d9

Force67 · 2024-10-01T06:07:24Z

Code/client/ModCompat/BehaviorVar.h

+    Replacer* loadReplacerFromDir(const std::filesystem::path acDir);
+    std::vector<uint64_t> signatureMatches(const uint64_t acHash, const std::string acSignature) const;
+
+    std::vector<Replacer> behaviorPool; // Pool for loaded behaviours


Tiltedcore vector

Commit 2d989d9

Force67 · 2024-10-01T06:07:35Z

Code/client/ModCompat/BehaviorVar.h

+        const uint64_t acNewHash, const Replacer& acReplacer,
+        std::map<const std::string, const uint32_t>& acReverseMap);
+
+    std::vector<std::filesystem::path> loadDirs(const std::filesystem::path& acPATH);


Coding conventions? no camelCase

Commit 2d989d9

Force67 · 2024-10-01T06:12:25Z

Code/client/ModCompat/BehaviorVar.cpp

+}
+
+// Process a set of variables, adding them to the aVariableSet
+void processVariableSet(const std::map<const std::string, const uint32_t>& acReverseMap,


Needs tiltedcore types

Commit 2d989d9

Force67 · 2024-10-01T06:14:12Z

Code/client/ModCompat/BehaviorVar.cpp

+    std::vector<std::string> boolVar;
+    std::string tempString;  // Temp string
+
+    std::ifstream fileSig(signatureFile);


You cannot assume that this succceeds, handle error.

Commit 2d989d9

Fixed it. It's a pretty narrow window, though. The path is from a directory iterator just run; so either the file was just deleted in the last millisecond or the directory is read-protected; a lot more would break in the latter case.

Force67 · 2024-10-01T06:15:01Z

Code/client/ModCompat/BehaviorVar.cpp

+// Find any behaviors which match the signature.
+// There should be exactly one.
+//
+std::vector<uint64_t> BehaviorVar::signatureMatches(const uint64_t acHash, const std::string acSignature) const


String by copy is a bad idea. maybe a string view?

Commit 2d989d9

Force67 · 2024-10-01T06:16:20Z

Code/client/ModCompat/BehaviorVar.h

+        std::string signatureVar;
+        std::string creatureName;
+        std::vector<std::string> syncBooleanVar;
+        std::vector<std::string> syncFloatVar;


No std types. use tiltedcore.

Commit 2d989d9

Code/client/ModCompat/BehaviorVar.h

rfortier · 2024-10-01T15:31:51Z

I'll run through your review comments. Tried to follow the style guide, but at least missed capitalized funcs/methods. Time to figure out the clang formatter, I guess.

Looks like a VS reinstall lost my tabs->4spaces setting. Is that the source of the generic "spacing" comment? And will clang formatter fix it? Otherwise I can do it manually.

Looks like I missed converting some contributed code to TiltedPhoques::. But one is deliberate; if I remember right TiltedPhoques::Map and ::Set are hashmaps, and I needed a sorted map / set; is there one?

Found TiltedPhoques::SortedMap, but it doesn't look like there is a sorted set.

Performance isn't super-critical for these, as they are only used once per creature type per launch (as in, once for all humanoids, once for all dragons...). So even if TP::SortedMap is slower, it won't hurt anything.

STR is up against the limit, using 62 of a hardwired 64 boolean behavior vars to be synced. This fix removes the limit before it becomes a barrier. Since "unlimited" will bite us, note the base code has some lengths encoded in 16-bit ints that will bite eventually. Trying to sync even a fraction of that many will cause problems, though. Reimplemented the Boolean long long as a (bit) Vector. This made all vars (bools, ints, floats) vectors, so some code simplification of the wire protocol is accessible. The Booleans are just passed "as is," no attempt to detect which ones changed as the space required to send the delta is more than just sending the bits. Overall impact on wire protocol: sending humanoids will be slightly longer, as the 64-bits available is almost full. But that's longer by a byte (or maybe two since I used String to simplify the code). Everything else sent will be shorter and less overhead. There's no avoiding iterating the bits of the Vector<bool>. But the overhead when translating the array of <bool> to an array of bits and back is about the same. There was a bunch of extra overhead if Serialization::WriteBool() were to be used, so optimized that part out. Overall, should be better on the wire, and neutral-to-better on CPU. 2nd commit msg: Reworked creating and applying Behavior variable diffs and serializing them. Simpler, easier to read, should usually save bytes on the wire.

…that it's a Vector; initial load-in animation variables might be empty.

…eplacer

…odded behavior. We want to detect this at runtime (like Edho did) so we can merge the STR team's behavior vars with the modded behavior vars (and not require mods to know what the STR devs picked to sync). This will also give substantial version independence, where this feature should work with multiple versions of STR.

Solve player 1st person woes Lighten intrusion into STR main body (References.cpp) Fixed sorting of AnimationGraphDescriptor behavior variables, this will help when Pandora is more widely adopted (and stops reordering behavior variables, maybe we can get to mod order independence). Added failList of modded behavior lookups that fail, so we don't repeat expensive failed calls. Even some built-in ones can fail, like wisps. Deleted dead code, marked some I'm not sure about for deletion. Update README.md with a decent description of the content and goals of the fork. Cleanups, comments about how it works.

Move SkyrimTogetherReborn\behaviors directory up a level to SkyrimTogetherRebornBehaviors. This gets modders out of the business of changing things in SkyrimTogetherReborn directory, and should make it it easire for mod authors to patch. Created default behavior mod directories for the supported creatures, so modders don't have to find hashes or signatures, they can just drop in behaviorvars they need. Translated Code\encoding\Struct\* files using code generation PowerShell script. Eventually will run automatically. Eventually may get STR Dev permission to eliminate it. Now when finding modded behavior with game base behaviors, translates the "old" numeric BehaviorVar values back to strings, then looks up the string to get the new numeric value. This means mod developers no longer need to know which variables STR Devs require. Better warning messages when lookups fail to aid hunting down the issue.

…game (lower case "speed"). If we get a miss on Speed try again with "speed". If this is the only one, this is a safer fix than going to case-insensitive search, which could have its own issues. Raised the log level to Error for these sorts of things.

Support remembering the modded humanoid/Master hash so exiting a beast modes can return to that (vs. a force-plug of the original unmodded behavior).

Greatest changes are vastly improved error messages to warn when signatures are not unique (match multiple creatures). Those messages made possible improving many signatures. They also showed that 8 creatures simply are not unique; the only OrigVars they define are shared. Sometimes rearranged, but they all have the same 92 variables. A mod to one of these creatures will have to define a new unique signature, even if it means introducing a variable.

Incorporating MostExcellent's PR. We've observed several instances of the stock game having typos in variable names, like improper capitalization and the like. Tolerate case-sensitive misspellings. if a vanilla behavior variable isn't found, capitalize the first letter, the most common misspelling. Then try all lower case, then case insensitive. Things would be a lot easier if people paid attention to case-sensitive variable names.

… compile, and better mark the dead code for deletion.

…IONS-MODS.md with updated information.

…ehavior is modified (it always is with Nemesis installed). And fixed a case where humanoids exiting beast mode would similarly fail if Nemesis wasn't installed.

…rings must be compared case-independent to match.

…ev-selected variables are now merged with what the mods need, so it is no longer necessary to request inclusion. And it's probably confusing as they shouldn't be there (and devs could change them).

…COMPATIBILITY. Should be an xmake option, but that doesn't seem to work properly.

… now. clang-format will get an isolated commit. Replaces lingering std:: types with TiltedPhoques:: types wherever feasible; there are a couple of cases where TP is missing function or breaks type conversion. Applies style guide naming conventions where there were misses. Fixes missing failure check on file opens. The paths must exist (they are from a directory iterator), but read permission could be missing. Cleaned up readme.

Also rebase to lateest /dev

…t always compiled now.

New to remember the modified MasterBehavior hash, since it is used to return from Beast mode. Previous implementation stored in ActorExtension, but would only get set on the first modified humanoid which might not be the PlayerCharacter. Similar issue for dragons, remember the modified hash so Actor::IsDragon() test will work for all modded dragons, not just the first one.

…/TiltedEvolution-rwf into feat-modded-anim-compat

rfortier mentioned this pull request Apr 28, 2024

Remove limit to BehaviorVars on the wire. #658

Closed

rfortier force-pushed the feat-modded-anim-compat branch from 3d9bc9c to b89538b Compare April 29, 2024 22:03

RobbeBryssinck reviewed May 5, 2024

View reviewed changes

rfortier force-pushed the feat-modded-anim-compat branch 2 times, most recently from 007c76e to 480e299 Compare May 5, 2024 20:30

rfortier force-pushed the feat-modded-anim-compat branch 3 times, most recently from 56a72bd to 33ce16b Compare May 20, 2024 18:33

rfortier changed the base branch from dev to master May 20, 2024 18:35

rfortier force-pushed the feat-modded-anim-compat branch from 33ce16b to b5a37c0 Compare May 26, 2024 15:10

rfortier force-pushed the feat-modded-anim-compat branch 3 times, most recently from 56d3242 to 191a63c Compare September 30, 2024 23:54

Force67 requested changes Oct 1, 2024

View reviewed changes

rfortier changed the base branch from master to dev October 1, 2024 17:51

rfortier force-pushed the feat-modded-anim-compat branch 3 times, most recently from 6db7bd0 to ad2fb18 Compare October 4, 2024 13:12

rfortier force-pushed the feat-modded-anim-compat branch from ad2fb18 to 5121ad4 Compare October 27, 2024 17:13

rfortier and others added 5 commits November 1, 2024 09:59

A bit more space efficiency for negative integers.

d242b01

Fixes a potential out-of-bounds reference to aVariables.Booleans now …

68bb27d

…that it's a Vector; initial load-in animation variables might be empty.

Merge Spvvd's BehaviorVar.cpp and related changes.feat: manual hash r…

253db37

…eplacer

Spvvd and others added 26 commits November 1, 2024 10:06

Update README.md with credits.

c713698

Update README.md

0ac0632

Beast mode support.

ecfc002

Support remembering the modded humanoid/Master hash so exiting a beast modes can return to that (vs. a force-plug of the original unmodded behavior).

Updated README.md

ed1f93e

README.md update

087e261

Better logging

8ed94cc

Behavior strings generator improvements to support Fallout4

f30bb9f

Fix #ifdefs to clean up the MODDED_BEHAVIOR_COMPATIBILITY conditional…

2e0cc0f

… compile, and better mark the dead code for deletion.

Revert all changes to the standard README.md. Add a new README-ANIMAT…

7225a35

…IONS-MODS.md with updated information.

Style guide fixes.

cd441cd

Corrected two issues: found IsDragon() test was failing when dragon b…

e1ef621

…ehavior is modified (it always is with Nemesis installed). And fixed a case where humanoids exiting beast mode would similarly fail if Nemesis wasn't installed.

Correct typo.

93cf9b5

Bugfix for case I haven't seen but may happen, where variable name st…

2949d89

…rings must be compared case-independent to match.

Clearer error message.

fe4dfa9

Move magic_enum.hpp to its proper home in \Libraries

4af29d1

Clean up now-redundant behavior variable declarations. The base STR D…

232e906

…ev-selected variables are now merged with what the mods need, so it is no longer necessary to request inclusion. And it's probably confusing as they shouldn't be there (and devs could change them).

Isolated change to enable conditional compilation of MODDED_BEHAVIOR_…

8f7a18c

…COMPATIBILITY. Should be an xmake option, but that doesn't seem to work properly.

clang-format changes in isolated commit

7b3dad7

Also rebase to lateest /dev

Removed MODDED_BEHAVIOR_COMPATIBILITY conditional compilation; suppor…

6570778

…t always compiled now.

rfortier force-pushed the feat-modded-anim-compat branch from e751157 to 479ca9f Compare November 1, 2024 14:06

rfortier added 2 commits November 1, 2024 10:17

Merge branch 'feat-unlimited-behavior-vars' into feat-modded-anim-compat

b1983c3

Merge branch 'feat-modded-anim-compat' of https://github.com/rfortier…

137e332

…/TiltedEvolution-rwf into feat-modded-anim-compat

RobbeBryssinck merged commit d6ce567 into tiltedphoques:dev Nov 3, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: support for behavior mods #659

Feature: support for behavior mods #659

rfortier commented Apr 25, 2024 •

edited

Loading

rfortier commented Apr 25, 2024

rfortier commented Apr 28, 2024

RobbeBryssinck commented May 5, 2024

RobbeBryssinck May 5, 2024

rfortier May 5, 2024 •

edited

Loading

RobbeBryssinck May 5, 2024

rfortier May 5, 2024

rfortier commented May 20, 2024

rfortier commented Sep 30, 2024 •

edited

Loading

Force67 Oct 1, 2024

rfortier Oct 2, 2024 •

edited

Loading

Force67 Oct 1, 2024

Force67 Oct 1, 2024

rfortier Oct 2, 2024 •

edited

Loading

Force67 Oct 1, 2024

rfortier Oct 2, 2024

Force67 Oct 1, 2024

rfortier Oct 2, 2024 •

edited

Loading

Force67 Oct 1, 2024

rfortier Oct 2, 2024

Force67 Oct 1, 2024

rfortier Oct 2, 2024

Force67 Oct 1, 2024

rfortier Oct 2, 2024

Force67 Oct 1, 2024

rfortier Oct 2, 2024

Force67 Oct 1, 2024

rfortier Oct 2, 2024

rfortier commented Oct 1, 2024 •

edited

Loading

Feature: support for behavior mods #659

Feature: support for behavior mods #659

Conversation

rfortier commented Apr 25, 2024 • edited Loading

Theory of Operation (how it works)

Directory Layout / Changes

Theory of Operations

rfortier commented Apr 25, 2024

rfortier commented Apr 28, 2024

RobbeBryssinck commented May 5, 2024

Choose a reason for hiding this comment

rfortier May 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfortier commented May 20, 2024

rfortier commented Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

rfortier Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfortier Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfortier Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfortier commented Oct 1, 2024 • edited Loading

rfortier commented Apr 25, 2024 •

edited

Loading

rfortier May 5, 2024 •

edited

Loading

rfortier commented Sep 30, 2024 •

edited

Loading

rfortier Oct 2, 2024 •

edited

Loading

rfortier Oct 2, 2024 •

edited

Loading

rfortier Oct 2, 2024 •

edited

Loading

rfortier commented Oct 1, 2024 •

edited

Loading