-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom keybinds #724
Open
ToeKneeRED
wants to merge
30
commits into
tiltedphoques:dev
Choose a base branch
from
ToeKneeRED:add/rebind-keys
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add custom keybinds #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebinding additions: - user can hit escape while rebinding and not close the STR UI - debug key rebinding
fix: config key loading refactor: general cleanup/clarifications, clang format
i misread an #if :)
also more cleanup
- start on reveal players keybind - remove some duplicated code - move towards enum-driven key selection for binding rather than requiring dedicated SetKey functions to be called externally
…eveal players keybind fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on tiltedphoques/TiltedHooks#7
NOTES:
List of known acceptable key names (should accept any single-character key based on keyboard layout as well): Backspace, Tab, Enter, LSHIFT, RSHIFT, LCTRL, RCTRL, LALT, RALT, Pause, Caps Lock, IME Kana mode, IME Kanji mode, Esc, IME convert, IME nonconvert, Space, Page Up, Page Down, End, Home, Arrow Left, Arrow Up, Arrow Right, Arrow Down, Ins, Del, LWIN, RWIN, Applications, Sleep, NUMPAD 0, NUMPAD 1, NUMPAD 2, NUMPAD 3, NUMPAD 4, NUMPAD 5, NUMPAD 6, NUMPAD 7, NUMPAD 8, NUMPAD 9, NUMPAD *, NUMPAD +, NUMPAD -, NUMPAD ., NUMPAD /, F1, F2, F3, F4, F5, F6, F7, F8, F9, F10, F11, F12, F13, F14, F15, Num Lock, ScrLk, Browser Back, Browser Forward, Browser Refresh, Browser Stop, Browser Search, Browser Favorites, Browser Home, Volume Mute, Volume Down, Volume Up, Next Track, Previous Track, Stop Media, Start Mail, Select Media
ex.
[Keybinds]
sUiKey=RCTRL
sDebugKey=]
sRevealPlayersKey=à
KeybindService
keybinds.ini
config file, sets keys (for KeybindService, InputService, and DebugService)OnVirtualKeyPress
or DirectInput viaOnDirectInputKeyPress
BindKey
KeybindService::Keybind
enum value)InputService
Toggle
to call all the necessary UI toggle codeKeyPressEvent
to send out VirtualKey as necessaryDebugService
m_debugKeyPressed
to managem_showDebugStuff
MagicService
RevealKeybindPressed
m_revealKeybindPressed