-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken when used with lerna bootstrap --hoist #65
Labels
Comments
Adding this as a note on this issue. |
This is also broken w/ yarn workspaces (same thing, basically) |
For now, we're doing this after our yarn install/lerna bootstrap: ln -s ../../../node_modules/react-scripts packages/our-app/node_modules/react-scripts |
Noting this https://github.com/viewsdx/yarn-workspaces-cra-crna From the Medium post |
Happy to accept a PR on this ... Going to close concluding #65 (comment) as a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lerna bootstrap --hoist moves all shared node_modules deps of packages into the lerna root directory.
react-app-rewired (RAR) is building the create react app (CRA) webpack path from cwd of the project being built, which node_modules folder won't have either CRA or RAR, so it chokes.
Will need to resolve CRA's webpack config from RAR's node modules location.
build.js -
const webpackConfig = paths.scriptVersionDir + '/config/webpack.config.prod';
The text was updated successfully, but these errors were encountered: