Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pat: Generalize shell-style patterns #319

Closed
timbray opened this issue Jun 17, 2024 · 1 comment
Closed

Pat: Generalize shell-style patterns #319

timbray opened this issue Jun 17, 2024 · 1 comment

Comments

@timbray
Copy link
Owner

timbray commented Jun 17, 2024 •
edited
Loading

With the addition of epsilon transitions to the Quamina NFA, there is no good reason to restrict shell style patterns to just one * glob. So things like push-*-c* should be OK. This would have the advantage that we could adopt a bunch more Ruler tests and benchmarks. Also… first new feature in 2 years.
timbray added a commit that referenced this issue Jun 18, 2024
@timbray
pat: remove single-* restriction on shellstyle
6efadb9 
addresses issue #319

Signed-off-by: Tim Bray <tbray@textuality.com>
timbray added a commit that referenced this issue Jun 27, 2024
@timbray
pat: remove limit of one * in shell style (#320)
78e2ec8 
* pat: remove single-* restriction on shellstyle

addresses issue #319

Signed-off-by: Tim Bray <tbray@textuality.com>

* fix lint nit

Signed-off-by: Tim Bray <tbray@textuality.com>

* back off to go 1.19 for compatibility

Signed-off-by: Tim Bray <tbray@textuality.com>

* remove slices library, which breaks GitHub CI

Signed-off-by: Tim Bray <tbray@textuality.com>

---------

Signed-off-by: Tim Bray <tbray@textuality.com>
@timbray
Copy link
Owner Author

timbray commented Jun 28, 2024

Fixed in #320

@timbray timbray closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timbray