-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClassApplier module alter contents of style tag #281
Comments
Also |
Good point. I'll fix this. Thanks for the clear test case. |
timdown
pushed a commit
that referenced
this issue
Mar 10, 2015
…le, script and some other elements.
Fixed. Elements that may contain text that are now ignored: |
The problem is fixed now. Thank you @timdown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I see a combination of
Highlighter
module andClassApplier
module alters content ofstyle
tag, but this tag definitely must not be touched. Here is the test case:How to reproduce:
.highlight {background-color: lime;}
.third
), click on "Highlight" button and then click on "Show style". You'll get.highlight {background-color: lime;}
and it's correct behavior too. Also the contents will be highlighted with lime color.first div The second
), click on "Highlight". The contents will not be highlighted although a wrapper span tag will be created. Moreover, if you click on "Show style" FF alerts nothing while IE alerts<span class="highlight">.highlight {background-color: lime;}</span>
which means that the contents of style tag are affected too.I'm using Rangy 1.3.0-beta.1 and test the behavior in FF36 and IE11.
UPD: The
ClassApplier
also alters contents ofscript
tags in the same conditions.The text was updated successfully, but these errors were encountered: