Highlight join #228
Merged
Highlight join #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Overlapping highlights of same class where not merging correctly. - `className` param can be `false` to erase existing highlights (maybe not so clean to implement it here) - `exclusive` param, if `true` highlights with different `classApplier` are removed from ranges (check for `className` instead of `classApplier`?) `CharacterRange.prototype.complements` was added for ranges subtraction
|
This looks really good. I've merged your changes locally, I'm going to write and run some tests and push when I'm done. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classNameparam can befalseto erase existing highlights (maybe not so clean to implement it here)exclusiveparam, iftruehighlights with differentclassApplierare removed from ranges (check forclassNameinstead ofclassApplier?)CharacterRange.prototype.complementswas added for ranges subtraction