Refine website controller mechanisms #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the status centrally and avoids status updates if nothing changed. Also, this allows adding a transition timestamp to the status as we can detect when the status changed.
- replace custom predicates with `predicate.GenerationChangedPredicate` - also watch spec changes to `Deployments` to reconcile them back if needed
This allows us to track how long website reconciliations take as observed by the controller itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves several aspects of the website controller's mechanisms:
Website.status.lastTransitionTimeindicating whenobservedGenerationand/orphasechanged the last time (useful for verifying reconciliation latency measurements)This prepares the controller for reconciliation latency measurements during load tests, used for evaluation.