webhosting-operator: drop legacy sharder implementation, use shard library #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the sharding implementation in the controller-runtime fork, webhosting-operator now uses the shard library for complying with the external sharder implementation (similar to the example shard). The internal sharder implementation is dropped accordingly.
timebertt
force-pushed
the
harmonize-modules
branch
from
a0d1541
to
2de3ab3
Compare
Create a new cluster at STACKIT replacing the dedicated Gardener environment.
timebertt
force-pushed
the
harmonize-modules
branch
from
2de3ab3
to
749bdef
Compare
timebertt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The webhosting-operator is developed in a dedicated module to prevent dependencies from leaking into the main module which contains the shard library.
Previously, the webhosting-operator depended on a fork of the controller-runtime library including the internal sharder implementation from the first project iteration (https://github.com/timebertt/controller-runtime/tree/sharding-0.15). This fork is based on controller-runtime v0.15.
In the second iteration, I kept the legacy sharder implementation to compare it with the external sharder approach.
Now the second project iteration is done and the external sharder implementation is the chosen approach.
Hence, this PR drops the legacy implementation and adapts webhosting-operator to use the shard library from the main module (as described in Implement Sharding in Your Controller).
For this, the PR performs several larger refactorings:
gocommand can be executed from the project root for the webhosting-operator module as wellSpecial notes for your reviewer:
TODO: