bug/60 mapcolumn cant nested types that have a comma #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yibo-Chen13
force-pushed
the
60-mapcolumn-cant-nested-types-that-have-a-comma
branch
from
3bbec06 to
2ac989b
Compare
tests/columns/test_map.py
Outdated
| @@ -22,7 +23,7 @@ def _sorted_dicts(self, text): | |||
| return '\n'.join(items) + '\n' | |||
|
|
|||
| def test_simple(self): | |||
| with self.create_stream('a map(string, uint64)'): | |||
| with self.create_stream('a map(string, int)'): | |||
There was a problem hiding this comment.
why change to int?
please remove the commented tests below if they are invalid.
yuzifeng1984
approved these changes
Nov 29, 2024
Yibo-Chen13
force-pushed
the
60-mapcolumn-cant-nested-types-that-have-a-comma
branch
from
2ac989b to
d848454
Compare
Yibo-Chen13
force-pushed
the
60-mapcolumn-cant-nested-types-that-have-a-comma
branch
from
d848454 to
c5b4ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.