Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 297 random stream supports slow eps #507

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

lizhou1111
Copy link
Contributor

@lizhou1111 lizhou1111 commented Jan 19, 2024

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

  1. Random stream supports slow eps, such as settings eps = 0.5 means every 2 second generating 1 data.
timeplus-OptiPlex-7000 :) select *,now() from test_random settings eps=0.5

SELECT
  *, now()
FROM
  test_random
SETTINGS
  eps = 0.5

Query id: 17a2b923-6027-4d8c-b18d-f3fe1a2d0581

┌──────────id─┬────────────────_tp_time─┬───────────────now()─┐
│ -10358622182024-01-19 10:17:28.8132024-01-19 18:17:28 │
└─────────────┴─────────────────────────┴─────────────────────┘
┌────────id─┬────────────────_tp_time─┬───────────────now()─┐
│ 2568397922024-01-19 10:17:30.8042024-01-19 18:17:30 │
└───────────┴─────────────────────────┴─────────────────────┘
  1. refactor RandomSource, the former code are hard to read and maintain.

@lizhou1111 lizhou1111 marked this pull request as ready for review January 19, 2024 10:19
@lizhou1111 lizhou1111 self-assigned this Jan 19, 2024
@lizhou1111 lizhou1111 force-pushed the feature/issue-297-random-stream-supports-slow-eps branch from 2bdac29 to f63809a Compare January 22, 2024 01:56
@lizhou1111 lizhou1111 force-pushed the feature/issue-297-random-stream-supports-slow-eps branch from f63809a to 7badb69 Compare January 23, 2024 09:26
@lizhou1111 lizhou1111 force-pushed the feature/issue-297-random-stream-supports-slow-eps branch 2 times, most recently from 7aecd31 to 190f5e1 Compare January 24, 2024 14:08
@lizhou1111 lizhou1111 force-pushed the feature/issue-297-random-stream-supports-slow-eps branch from 190f5e1 to 647b377 Compare January 24, 2024 14:10
Copy link
Collaborator

@yl-lisen yl-lisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, it's easy to understand.

@yl-lisen yl-lisen merged commit ddd0428 into develop Jan 25, 2024
21 checks passed
@yl-lisen yl-lisen deleted the feature/issue-297-random-stream-supports-slow-eps branch January 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants