Disable V8_HAS_PKU_JIT_WRITE_PROTECT to workaround dlsym

upstream: v8/v8@1872607#diff-b6929ffe2ee2f4fbaccb9b2407e4d21f76fca8f17f5388affa4e1ff8690d83c1L20 credit: replayio/chromium-v8#80
timeplus-io · Dec 3, 2024 · 51bae8c · 51bae8c
1 parent 272e534
commit 51bae8c
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/v8/src/base/build_config.h b/v8/src/base/build_config.h
@@ -35,11 +35,14 @@
 #define V8_HAS_PTHREAD_JIT_WRITE_PROTECT 0
 #endif
 
-#if defined(V8_OS_LINUX) && defined(V8_HOST_ARCH_X64)
-#define V8_HAS_PKU_JIT_WRITE_PROTECT 1
-#else
+// [timeplus proton] upstream change this behaviour, intend to manually disabled to less review burden
+// see https://github.com/v8/v8/commit/187260760a5e3ba2493cc7f2c3b669131ba57625#diff-b6929ffe2ee2f4fbaccb9b2407e4d21f76fca8f17f5388affa4e1ff8690d83c1L20
+// #if defined(V8_OS_LINUX) && defined(V8_HOST_ARCH_X64)
+// #define V8_HAS_PKU_JIT_WRITE_PROTECT 1
+// #else
+// #define V8_HAS_PKU_JIT_WRITE_PROTECT 0
+// #endif
 #define V8_HAS_PKU_JIT_WRITE_PROTECT 0
-#endif
 
 #if defined(V8_TARGET_ARCH_IA32) || defined(V8_TARGET_ARCH_X64)
 #define V8_TARGET_ARCH_STORES_RETURN_ADDRESS_ON_STACK true