chore(text_to_sql): various prompt eng tweaks and minor fixes #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jgpruitt
commented
Feb 12, 2025
•
jgpruitt
commented
- prompt engineering stuff mostly with openai
- minor bug fixes
MasterOdin
approved these changes
Feb 12, 2025
| }, | ||
| "total": { | ||
| "type": "integer", | ||
| "minimum": 1, | ||
| "maximum": 100, | ||
| "default": 10, | ||
| "description": "The total number of rows to return in the sample, the max is 10." |
There was a problem hiding this comment.
Can probably remove the max bit in the description.
Comment on lines
+372
to
+376
| , tool_choice=> | ||
| case when _iter_remaining = 0 then | ||
| '{"type": "function", "function": {"name": "answer_user_question_with_sql_statement"}}' | ||
| else 'required' | ||
| end |
There was a problem hiding this comment.
Why not do this with at least anthropic as well?
adolsalamanca
approved these changes
Feb 12, 2025
MasterOdin
requested changes
Feb 12, 2025
jgpruitt
force-pushed
the
jgpruitt/text-to-sql-hackery
branch
from
955ce24 to
ce3be52
Compare
MasterOdin
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.