Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync workflow with tsdb repo #202

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

fabriziomello
Copy link
Contributor

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this runs against main we dont need to keep previous api around here

We only need to add _timescaledb_functions.policy_compression_execute(job_id integer,htid integer,lag anyelement,maxchunks integer,verbose_log boolean,recompress_enabled boolean,use_creation_time boolean,amname name)

Since you also change it to variable its kinda hard to see what the actual change is.

@JamesGuthrie JamesGuthrie removed their request for review October 21, 2024 08:00
@fabriziomello
Copy link
Contributor Author

Since this runs against main we dont need to keep previous api around here

We only need to add _timescaledb_functions.policy_compression_execute(job_id integer,htid integer,lag anyelement,maxchunks integer,verbose_log boolean,recompress_enabled boolean,use_creation_time boolean,amname name)

Since you also change it to variable its kinda hard to see what the actual change is.

Make sense. Fixed!

@fabriziomello fabriziomello merged commit f5bc5d8 into timescale:main Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants