Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Adds support for reloader in Promscale. #1426

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

Harkishen-Singh
Copy link
Member

@Harkishen-Singh Harkishen-Singh commented Jun 10, 2022

Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com

Fixes: https://github.com/timescale/o11y-team-applications/issues/182

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

Copy link
Contributor

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho this is over-engineered. The code could be simplified a lot. We only need to reload rules.

Copy link
Contributor

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd just like to see some tests (either unit or e2e)

pkg/runner/runner.go Outdated Show resolved Hide resolved
pkg/tests/end_to_end_tests/rules_test.go Outdated Show resolved Hide resolved
pkg/tests/end_to_end_tests/rules_test.go Outdated Show resolved Hide resolved
pkg/tests/end_to_end_tests/rules_test.go Outdated Show resolved Hide resolved
@Harkishen-Singh Harkishen-Singh force-pushed the hot_reload_arch branch 2 times, most recently from e293e67 to 234ac99 Compare June 15, 2022 09:10
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
@Harkishen-Singh Harkishen-Singh merged commit 8739804 into timescale:master Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants