This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 168
Adds support for reloader in Promscale. #1426
Merged
Harkishen-Singh
merged 1 commit into
timescale:master
from
Harkishen-Singh:hot_reload_arch
Jun 16, 2022
Merged
Adds support for reloader in Promscale. #1426
Harkishen-Singh
merged 1 commit into
timescale:master
from
Harkishen-Singh:hot_reload_arch
Jun 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harkishen-Singh
force-pushed
the
hot_reload_arch
branch
from
June 13, 2022 09:54
42ec0b2
to
60e3bf7
Compare
Harkishen-Singh
force-pushed
the
hot_reload_arch
branch
from
June 13, 2022 09:58
60e3bf7
to
48a326e
Compare
antekresic
reviewed
Jun 13, 2022
niksajakovljevic
suggested changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho this is over-engineered. The code could be simplified a lot. We only need to reload rules.
Harkishen-Singh
force-pushed
the
hot_reload_arch
branch
3 times, most recently
from
June 14, 2022 11:09
9f1fb1e
to
2b6f4ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd just like to see some tests (either unit or e2e)
Harkishen-Singh
force-pushed
the
hot_reload_arch
branch
from
June 14, 2022 13:18
2b6f4ec
to
0140acc
Compare
antekresic
reviewed
Jun 15, 2022
niksajakovljevic
approved these changes
Jun 15, 2022
Harkishen-Singh
force-pushed
the
hot_reload_arch
branch
2 times, most recently
from
June 15, 2022 09:10
e293e67
to
234ac99
Compare
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Harkishen-Singh
force-pushed
the
hot_reload_arch
branch
from
June 15, 2022 12:44
234ac99
to
aebccfd
Compare
antekresic
approved these changes
Jun 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Fixes: https://github.com/timescale/o11y-team-applications/issues/182
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: