This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Remove flaky PromscaleCacheTooSmall alert
#1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
force-pushed
the
remove-PromscaleCacheTooSmall-alert
branch
from
3a98cd0
to
8f07fbf
Compare
This commit removes the alert PromscaleCacheTooSmall which is flaky and fires during same cause as `PromscaleCacheHighNumberOfEvictions`. Fixes timescale#1356. Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar
force-pushed
the
remove-PromscaleCacheTooSmall-alert
branch
from
8f07fbf
to
4fe26f5
Compare
| sum by (job, instance, name, type) ( | ||
| promscale_cache_capacity_elements | ||
| ) | ||
| rate(promscale_cache_evictions_total[5m]) |
There was a problem hiding this comment.
Could you explain why it's no longer necessary to sum by ... here?
There was a problem hiding this comment.
The metric has only 4 labels(2 app labels[name, type] and 2 scrape labels[job, instances]), there is no reason to use sum by as it would yield the same result even without that.
JamesGuthrie
approved these changes
Jul 18, 2022
paulfantom
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the alert PromscaleCacheTooSmall which is flaky and fires during same cause as
PromscaleCacheHighNumberOfEvictions.Fixes #1356.
Signed-off-by: Arunprasad Rajkumar ar.arunprasad@gmail.com
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: