This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Make Jaeger Event queryable using event name and event tags #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
changed the title
arajkumar
added
the
action:benchmarks
niksajakovljevic
approved these changes
Aug 10, 2022
Harkishen-Singh
suggested changes
Aug 10, 2022
So far we were matching tags present only in span, however Jaeger supports query on tags present in Event too. Fixes timescale#1552 Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar
removed
the
action:benchmarks
Harkishen-Singh
approved these changes
Aug 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far we were matching tags present only in span, however Jaeger supports query on tags present in Event too. This commit matches tags in event table by joining span and event table based on span_id and trace_id.
Fixes #1552
Signed-off-by: Arunprasad Rajkumar ar.arunprasad@gmail.com
Note: If your PR involves benchmarks, you can run the
Benchmarksworkflow by addingaction:benchmarkslabel. The PR must be opened from Promscale branch so that Github actions can leave a comment comparing results againstmaster.Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: