This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix: Do not collect telemetry if set to off
#1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harkishen-Singh
force-pushed
the
telemetry_engine_respect_db_state
branch
2 times, most recently
from
a613eb6
to
8ac89fc
Compare
alejandrodnm
approved these changes
Sep 2, 2022
Harkishen-Singh
force-pushed
the
telemetry_engine_respect_db_state
branch
2 times, most recently
from
a1512f2
to
676f4bb
Compare
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Harkishen-Singh
force-pushed
the
telemetry_engine_respect_db_state
branch
from
676f4bb
to
ea1f9e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1413
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
This commits updates the telemetry engine to start, irrespective of
whether
timescaledb.telemetry_levelisonoroff. However,collection of telemetry happens only when the
telemetry_levelison.This allows the telemetry engine to either start telemetry collection
if it was disabled in the starting, but enabled later on, or stop
telemetry collection if it was enabled in the starting but disabled
later on.
Description
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: