This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix: 0 samples/sec in throughput by logging metric metadata throughput
#1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harkishen-Singh
requested review from
antekresic,
arajkumar and
alejandrodnm
Harkishen-Singh
force-pushed
the
throughput_for_metadata
branch
from
e7bbb27
to
2fbcaa5
Compare
alejandrodnm
approved these changes
Sep 14, 2022
Harkishen-Singh
force-pushed
the
throughput_for_metadata
branch
from
2fbcaa5
to
ed427d5
Compare
…put. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> This commit fixes `0 samples/sec` logging in throughput. The reason behind this behaviour was metric-metadata not being printed, rather it was just updating the `metrics-max-ts-send`, which was causing the log. The `metrics-max-ts-send` was updated even when we were writing metadata. This commit also updates the logging of throughput, by making samples, spans and metric-metadata log in the same line, than the earlier separate lines. This allows better utilization of log lines.
Harkishen-Singh
force-pushed
the
throughput_for_metadata
branch
from
ed427d5
to
353db62
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1642
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Description
This commit fixes
0 samples/seclogging in throughput. The reason behind this behaviour was metric-metadata not being printed, rather it was just updating themetrics-max-ts-send, which was causing the log.This
metrics-max-ts-sendwas updated even when we were writing metadata.Now, the log for metric, metric-metadata and spans will be in single line, compared to the earlier separate lines.
Update
Now we log like this.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: