Feike/use compiled artifacts #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feikesteenbergen
force-pushed
the
feike/use_compiled_artifacts
branch
2 times, most recently
from
f24996c to
a9184e6
Compare
|
|
feikesteenbergen
force-pushed
the
feike/use_compiled_artifacts
branch
from
a9184e6 to
2c89134
Compare
JamesGuthrie
approved these changes
Jul 12, 2022
feikesteenbergen
force-pushed
the
feike/use_compiled_artifacts
branch
from
2c89134 to
7a5295b
Compare
|
@feikesteenbergen great to see this changes! Just wanted to confirm with you on one thing. As you know, the toolkit only started to build one DEB package for all starting from 1.6.0. Before this release, we had a version built specifically for timescale cloud. Are 1.6.0, 1.7.0 and 1.8.0 sufficient releases for you for now? |
rtwalker
approved these changes
Jul 12, 2022
When installing .deb packages as the postgres user, /usr/share/doc needs to be owned by the postgres user. We fully remove this directory later on.
By using a clean /tmp/dpkg directory we ensure we do not remove files that belong to older versions of this package. That is good, as we want *multiple* versions to coexist in this Docker Image.
By using a clean /tmp/dpkg directory we ensure we do not remove files that belong to older versions of this package. That is good, as we want *multiple* versions to coexist in this Docker Image.
feikesteenbergen
force-pushed
the
feike/use_compiled_artifacts
branch
from
d197036 to
e5951d2
Compare
Yes, for us, they are. |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we compiled toolkit and promscale, multiple versions for multiple PostgreSQL versions.
The issue with that is that it was very time consuming, which isn't great for developing against this repository.
This was the situation before this commit:
By taking out Toolkit and Promscale from the compilation, we expect a reduction of
34.0%+48.2% = 82.2%in build times.