Fix UPSERT with prepared statements #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
========================================
Coverage ? 92.4%
========================================
Files ? 107
Lines ? 13689
Branches ? 0
========================================
Hits ? 12650
Misses ? 1039
Partials ? 0
Continue to review full report at Codecov.
|
svenklemm
force-pushed
the
upsert_bug
branch
3 times, most recently
from
84eeba1 to
33ed1b7
Compare
svenklemm
force-pushed
the
upsert_bug
branch
4 times, most recently
from
c5533d0 to
f137edd
Compare
cevian
approved these changes
Apr 30, 2019
| @@ -158,17 +158,6 @@ chunk_dispatch_end(CustomScanState *node) | |||
| ExecEndNode(substate); | |||
There was a problem hiding this comment.
There is a now-outdated comment at line 245 of this file.
There was a problem hiding this comment.
starts with "Save arbiterIndexes..."
When doing upsert with prepared statement the code to restore arbiter_indexes would not trigger when an error occurred on the INSERT leading to a segfault on the next EXECUTE of the prepared statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing upsert with prepared statement the code to restore
arbiter_indexes would not trigger when an error occurred on the
INSERT leading to a segfault on the next EXECUTE of the prepared
statement.
Fixes #1165