Bundled some changes to SQL and functions. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricklen
commented
Apr 11, 2017
bricklen
commented
- Converted a couple plpgsql functions to SQL functions, for a couple reasons: to allow the planner to optimize them in query plans, and to remove the cost of invoking the plpgsql procedural engine unnecessarily (the functions didn't need the full power of a procedural language, SQL was sufficient).
- Added the "-X" flag to several invocations of psql, so as to not source any customer .psqlrc the user might have set up. By sourcing the .psqlrc, there is a chance of unexpected results occurring when the scripts are executed (eg. pager settings could cause the terminal to hang at a prompt).
- Replaced several examples of assignment using "=" with ":=".
* Fixed bug in "table_oid::TEXT" section of the "TABLE_NAME" code. Executing `SELECT create_hypertable('my_table', 'time');` failed with `ERROR: Cannot process index with definition (no index name match)...`.
* Replaced "=" with the preferred ":=" assignment operator. Both are allowed, but the latter is less likely to cause subtle bugs due to equality vs assignment (I've run into it before).
* Qualified system relations with pg_catalog schema so there is no ambiguity.
* Dropped the "CREATE" keyword from the "replace()" function because it was failing to cover the case where an index had a definition like "CREATE UNIQUE INDEX".
* Updated some comments.
* Revised variable names to have a "v_" prefix to reduce the chance of a name collision between objects in a function (I've hit this in production before).
…in PostgreSQL 9.6.
|
Wrote this on your other PR, but also copying here: Thanks for the PR. We're in the process of getting ourselves ready to accept external contributions (e.g., putting together a style guide). Should have that ready soon. Also, noticed that the tests are failing. Think you need to change the expected test result to work with your changes? |
|
Closing in favour of a new, leaner version. The extra changes from this PR can be revisited at a later date. |
This was referenced Oct 8, 2017
This was referenced Aug 28, 2020
matthewmcnew
pushed a commit
that referenced
this pull request
Nov 4, 2024
Add XXL benchmark for ClickHouse Cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.