Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable #4159

konskov · 2022-03-11T08:50:05Z

When an ALTER TABLE ... ADD COLUMN IF NOT EXISTS ... command is executed
and the column already exists, we get an error message that the column already
exists on the compressed hypertable, even though IF NOT EXISTS is specified.
This PR removes this error.

Fix #4087

codecov · 2022-03-11T08:58:52Z

Codecov Report

Merging #4159 (8c7765b) into main (9c46a5d) will decrease coverage by 0.02%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main    #4159      +/-   ##
==========================================
- Coverage   90.76%   90.73%   -0.03%     
==========================================
  Files         215      215              
  Lines       39497    39497              
==========================================
- Hits        35848    35839       -9     
- Misses       3649     3658       +9

Impacted Files	Coverage Δ
src/planner.c	`95.17% <ø> (-0.01%)`	⬇️
src/ts_catalog/catalog.h	`100.00% <ø> (ø)`
src/extension.c	`86.27% <90.00%> (-4.02%)`	⬇️
src/cache_invalidate.c	`91.48% <100.00%> (-0.35%)`	⬇️
src/extension_utils.c	`95.45% <100.00%> (+0.10%)`	⬆️
src/ts_catalog/catalog.c	`83.81% <100.00%> (-0.99%)`	⬇️
tsl/src/compression/create.c	`96.51% <100.00%> (+0.02%)`	⬆️
tsl/src/fdw/relinfo.c	`96.83% <100.00%> (-0.02%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972afe0...8c7765b. Read the comment docs.

mfundul · 2022-03-11T10:38:34Z

tsl/src/compression/create.c

 {
 	Oid compress_relid = compress_ht->main_table_relid;
 	ColumnDef *coldef;
 	AlterTableCmd *addcol_cmd;
+	HeapTuple attTuple;
+	int attnum;
+	bool skipped = false; /* postgres operates on its table first, so the column may have been


You can't really assume this here. Maybe this function is going to be called from a different place in the future. There is no guarantee that postgres operated on its table first.

mfundul · 2022-03-11T10:55:13Z

tsl/src/compression/create.c

@@ -1057,28 +1087,31 @@ tsl_process_compress_table(AlterTableCmd *cmd, Hypertable *ht,
 * This function specifically adds the column to the internal compression table.
 */
 void
-tsl_process_compress_table_add_column(Hypertable *ht, ColumnDef *orig_def)
+tsl_process_compress_table_add_column(Hypertable *ht, const AlterTableCmd *cmd)


Why do you want to tie this to an ALTER TABLE command? We should be able to add a column on demand if we like. I don't see what missing_ok offers us here. In any case, if we really needed missing_ok we could add an extra bool argument.

In this case if missing_ok is true, then it is a no-op that prints a warning, otherwise it's an exception. Is this the idea here?

gayyappan · 2022-03-24T15:25:08Z

tsl/src/compression/create.c

+	else
+	{
+		ReleaseSysCache(attTuple);
+	}

 	/* alter the table and add column */
 	AlterTableInternal(compress_relid, list_make1(addcol_cmd), true);
 	modify_compressed_toast_table_storage(compress_cols, compress_relid);


This should be conditional -> do it only if a new column is added

gayyappan · 2022-03-24T15:26:13Z

tsl/src/compression/create.c

 		Assert(TS_HYPERTABLE_HAS_COMPRESSION_ENABLED(ht));
 	}
 	/* add catalog entries for the new column for the hypertable */
-	compresscolinfo_add_catalog_entries(&compress_cols, orig_htid);
+	if (new_column || no_compression_table)


add catalog entries only if this is a new column, otherwise you will have duplicates.

Suggested change

if (new_column || no_compression_table)

if (new_column )

gayyappan · 2022-03-24T15:28:31Z

tsl/src/compression/create.c

+		/* the column doesn't exist yet */
+		new_column = true;
+	}
+	else


why is Release conditional? Shouldn't this be released before leaving the function?

It is not needed when the search fails.

gayyappan · 2022-03-24T15:29:03Z

tsl/src/compression/create.c

 	}
 	else
 	{
+		no_compression_table = true;


this variable is not needed.

fabriziomello · 2022-03-24T15:49:22Z

tsl/src/compression/create.c

+	if (!HeapTupleIsValid(attTuple))
+	{
+		/* the column doesn't exist yet */
+		new_column = true;
+	}
+	else
+	{
+		ReleaseSysCache(attTuple);
+	}


Suggested change

if (!HeapTupleIsValid(attTuple))

{

/* the column doesn't exist yet */

new_column = true;

}

else

{

ReleaseSysCache(attTuple);

}

/* the column doesn't exist yet */

new_column = !HeapTupleIsValid(attTuple);

ReleaseSysCache(attTuple);

mkindahl

Hi! Patch looks good, but a few items that I think might be good to add a test for a compressed distributed table and make sure that it behaves in a sane manner.

The most sensible place to call the function to add a compressed table column is in process_altertable_end_subcmd, which is called after the main statement has executed. At this point you know that adding the column succeeded and that all that remains is to add the column to the compressed table. At this point is is not necessary to do any checking if the column exists and you can just proceed with executing the AlterTableStmt with the same options as before, but change the table name.

mkindahl · 2022-03-24T15:30:59Z

tsl/test/expected/compression_errors.out

+NOTICE:  column "medium" of relation "metric" already exists, skipping
+NOTICE:  column "medium" of relation "_compressed_hypertable_24" already exists, skipping


Nit: Is it possible to silence the second one? This uses a name for an internal tables and not particularly useful to the user. Feel free to skip this one.

Not sure if it's possible because it is a internal postgres message

It would be possible to set the missing_ok to false and then use PG_TRY and PG_CATCH to eliminate the message. Not critical though, so we could do it in a separate PR.

mkindahl · 2022-03-24T15:32:11Z

tsl/test/sql/compression_errors.sql

+ALTER TABLE metric ADD COLUMN IF NOT EXISTS "medium" VARCHAR ;
+-- also add one without IF NOT EXISTS 
+ALTER TABLE metric ADD COLUMN "medium_1" VARCHAR ;
+ALTER TABLE metric ADD COLUMN "medium_1" VARCHAR ;


Suggested change

ALTER TABLE metric ADD COLUMN "medium_1" VARCHAR ;

\set ON_ERROR_STOP 0

ALTER TABLE metric ADD COLUMN "medium_1" VARCHAR ;

\set ON_ERROR_STOP 1

mkindahl · 2022-03-24T16:02:11Z

tsl/src/compression/create.c

+		/* the column doesn't exist yet */
+		new_column = true;
+	}
+	else


It is not needed when the search fails.

mkindahl · 2022-03-24T16:16:41Z

The most sensible place to call the function to add a compressed table column is in process_altertable_end_subcmd, which is called after the main statement has executed. At this point you know that adding the column succeeded and that all that remains is to add the column to the compressed table. At this point is is not necessary to do any checking if the column exists and you can just proceed with executing the AlterTableStmt with the same options as before, but change the table name.

This might require some rewrite of the process_altertable_end_table, which makes the commit a lot bigger since it does not pass down the AlterTableStmt to the other functions, so that might be better to do as a refactoring of this code in a separate PR.

fabriziomello · 2022-03-25T17:01:20Z

@konskov looking more deeply for this PR I think (IMHO) is better to passdown the AlterTableCmd->missing_ok value to tsl_process_compress_table_add_column, add_column_to_compression_table and compresscolinfo_add_catalog_entries teaching the last one to check if the column already exists in our catalog if missing_ok = true to skip the insertion that lead us to a duplicate key violation

gayyappan

Minor change requested. Changes look good.

gayyappan · 2022-03-31T13:31:24Z

tsl/src/compression/create.c

@@ -1067,6 +1067,14 @@ tsl_process_compress_table_add_column(Hypertable *ht, ColumnDef *orig_def)

 	coloid = LookupTypeNameOid(NULL, orig_typname, false);
 	compresscolinfo_init_singlecolumn(&compress_cols, colname, coloid);
+
+	FormData_hypertable_compression *ht_comp =


I would move the newly added lines to line 1067.
So the check would be the first thing in the function (before any initialization etc) .

gayyappan · 2022-03-31T13:35:42Z

tsl/test/expected/dist_compression.out

+FROM generate_series('2021-07-01 00:00:00'::timestamp,
+                    '2021-08-17 00:02:00'::timestamp, '30 s'::interval) s;
+
+SELECT compress_chunk(show_chunks('metric'));


should rewrite the query with order by (so that test output is consistent)
SELECT compress_chunk(ch) FROM show_chunks('metric') ch ORDER BY 1;

mfundul · 2022-03-31T20:20:01Z

tsl/src/compression/create.c

+	if (ht_comp)
+	{
+		return;
+	}


Suggested change

if (ht_comp)

{

return;

}

if (ht_comp)

return;

I'm pretty sure the format check will pass if you simplify it this way.

Stop throwing exception with message "column of relation already exists" when running the command ALTER TABLE ... ADD COLUMN IF NOT EXISTS ... on compressed hypertables. Fix timescale#4087

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#3974 Fix remote EXPLAIN with parameterized queries * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #3974 Fix remote EXPLAIN with parameterized queries * #4122 Fix segfault on INSERT into distributed hypertable * #4142 Ignore invalid relid when deleting hypertable * #4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * #4161 Fix memory handling during scans * #4186 Fix owner change for distributed hypertable * #4192 Abort sessions after extension reload * #4193 Fix relcache callback handling causing crashes **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#4121 Fix RENAME TO/SET SCHEMA on distributed hypertable * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4176 Fix remote EXPLAIN with parameterized queries * timescale#4181 Fix spelling errors and omissions * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes * timescale#4199 Remove signal-unsafe calls from signal handlers * timescale#4219 Do not modify aggregation state in finalize **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#4121 Fix RENAME TO/SET SCHEMA on distributed hypertable * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4176 Fix remote EXPLAIN with parameterized queries * timescale#4181 Fix spelling errors and omissions * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes * timescale#4199 Remove signal-unsafe calls from signal handlers * timescale#4219 Do not modify aggregation state in finalize **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#4121 Fix RENAME TO/SET SCHEMA on distributed hypertable * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4176 Fix remote EXPLAIN with parameterized queries * timescale#4181 Fix spelling errors and omissions * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes * timescale#4199 Remove signal-unsafe calls from signal handlers * timescale#4219 Do not modify aggregation state in finalize **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#4121 Fix RENAME TO/SET SCHEMA on distributed hypertable * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4176 Fix remote EXPLAIN with parameterized queries * timescale#4181 Fix spelling errors and omissions * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes * timescale#4199 Remove signal-unsafe calls from signal handlers * timescale#4219 Do not modify aggregation state in finalize **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#4121 Fix RENAME TO/SET SCHEMA on distributed hypertable * timescale#4122 Fix segfault on INSERT into distributed hypertable * timescale#4142 Ignore invalid relid when deleting hypertable * timescale#4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * timescale#4161 Fix memory handling during scans * timescale#4176 Fix remote EXPLAIN with parameterized queries * timescale#4181 Fix spelling errors and omissions * timescale#4186 Fix owner change for distributed hypertable * timescale#4192 Abort sessions after extension reload * timescale#4193 Fix relcache callback handling causing crashes * timescale#4199 Remove signal-unsafe calls from signal handlers * timescale#4219 Do not modify aggregation state in finalize **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

@abrownsword

This release is a patch release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #4121 Fix RENAME TO/SET SCHEMA on distributed hypertable * #4122 Fix segfault on INSERT into distributed hypertable * #4142 Ignore invalid relid when deleting hypertable * #4159 Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable * #4161 Fix memory handling during scans * #4176 Fix remote EXPLAIN with parameterized queries * #4181 Fix spelling errors and omissions * #4186 Fix owner change for distributed hypertable * #4192 Abort sessions after extension reload * #4193 Fix relcache callback handling causing crashes * #4199 Remove signal-unsafe calls from signal handlers * #4219 Do not modify aggregation state in finalize **Thanks** * @abrownsword for reporting a crash in the telemetry reporter * @daydayup863 for reporting issue with remote explain

konskov requested a review from mfundul March 11, 2022 08:50

konskov force-pushed the addcol-compressed-fix branch from 3c1aac9 to 4a518f1 Compare March 11, 2022 10:06

konskov marked this pull request as ready for review March 11, 2022 10:18

konskov requested a review from a team as a code owner March 11, 2022 10:18

konskov requested review from berkley, duncan-tsdb and mkindahl and removed request for a team March 11, 2022 10:18

mfundul reviewed Mar 11, 2022

View reviewed changes

konskov marked this pull request as draft March 11, 2022 13:47

konskov force-pushed the addcol-compressed-fix branch 2 times, most recently from 6850ee8 to 53d3855 Compare March 14, 2022 10:54

mkindahl removed request for berkley and duncan-tsdb March 16, 2022 07:04

konskov self-assigned this Mar 16, 2022

konskov marked this pull request as ready for review March 24, 2022 15:10

konskov requested a review from fabriziomello March 24, 2022 15:14

gayyappan reviewed Mar 24, 2022

View reviewed changes

fabriziomello reviewed Mar 24, 2022

View reviewed changes

mkindahl reviewed Mar 24, 2022

View reviewed changes

konskov force-pushed the addcol-compressed-fix branch 2 times, most recently from 6f3bf88 to e663fb1 Compare March 31, 2022 12:49

konskov requested review from gayyappan, mfundul, fabriziomello and mkindahl March 31, 2022 13:03

gayyappan approved these changes Mar 31, 2022

View reviewed changes

gayyappan reviewed Mar 31, 2022

View reviewed changes

konskov force-pushed the addcol-compressed-fix branch from e663fb1 to aed4b24 Compare March 31, 2022 20:16

mfundul reviewed Mar 31, 2022

View reviewed changes

konskov force-pushed the addcol-compressed-fix branch from aed4b24 to d21277a Compare March 31, 2022 20:35

mfundul approved these changes Mar 31, 2022

View reviewed changes

Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable

8c7765b

Stop throwing exception with message "column of relation already exists" when running the command ALTER TABLE ... ADD COLUMN IF NOT EXISTS ... on compressed hypertables. Fix timescale#4087

konskov force-pushed the addcol-compressed-fix branch from d21277a to 8c7765b Compare April 1, 2022 07:32

konskov merged commit a154ae5 into timescale:main Apr 1, 2022

This was referenced Apr 5, 2022

Release 2.6.1 #4212

Merged

Release 2.6.1 #4213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable #4159

Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable #4159

konskov commented Mar 11, 2022

codecov bot commented Mar 11, 2022 •

edited

Loading

mfundul Mar 11, 2022

mfundul Mar 11, 2022

gayyappan Mar 24, 2022 •

edited

Loading

gayyappan Mar 24, 2022

gayyappan Mar 24, 2022

mkindahl Mar 24, 2022

gayyappan Mar 24, 2022

fabriziomello Mar 24, 2022

mkindahl left a comment •

edited

Loading

mkindahl Mar 24, 2022 •

edited

Loading

fabriziomello Mar 25, 2022

mkindahl Mar 25, 2022

mkindahl Mar 24, 2022

mkindahl Mar 24, 2022

mkindahl commented Mar 24, 2022 •

edited

Loading

fabriziomello commented Mar 25, 2022

gayyappan left a comment

gayyappan Mar 31, 2022

gayyappan Mar 31, 2022

mfundul Mar 31, 2022

		NOTICE: column "medium" of relation "metric" already exists, skipping
		NOTICE: column "medium" of relation "_compressed_hypertable_24" already exists, skipping

Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable #4159

Fix ADD COLUMN IF NOT EXISTS error on compressed hypertable #4159

Conversation

konskov commented Mar 11, 2022

codecov bot commented Mar 11, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gayyappan Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkindahl left a comment • edited Loading

Choose a reason for hiding this comment

mkindahl Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkindahl commented Mar 24, 2022 • edited Loading

fabriziomello commented Mar 25, 2022

gayyappan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 11, 2022 •

edited

Loading

gayyappan Mar 24, 2022 •

edited

Loading

mkindahl left a comment •

edited

Loading

mkindahl Mar 24, 2022 •

edited

Loading

mkindahl commented Mar 24, 2022 •

edited

Loading