Fix memory leak in function telemetry #4532

svenklemm · 2022-07-20T17:47:11Z

hash_create will create the hash table in TopMemoryContext unless
explicitly requested to create in different memory context. The
function telemetry code did not explicitly request a different
context leading to a memory leak.

Fixes #4507

hash_create will create the hash table in TopMemoryContext unless explicitly requested to create in different memory context. The function telemetry code did not explicitly request a different context leading to a memory leak.

codecov · 2022-07-20T18:11:01Z

Codecov Report

Merging #4532 (5bff287) into main (d561928) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #4532      +/-   ##
==========================================
+ Coverage   90.20%   90.23%   +0.02%     
==========================================
  Files         222      222              
  Lines       41088    41087       -1     
==========================================
+ Hits        37065    37073       +8     
+ Misses       4023     4014       -9

Impacted Files	Coverage Δ
src/telemetry/functions.c	`4.87% <0.00%> (+0.03%)`	⬆️
tsl/src/chunk_api.c	`94.90% <100.00%> (+<0.01%)`	⬆️
tsl/src/reorder.c	`85.37% <0.00%> (-0.27%)`	⬇️
tsl/src/nodes/data_node_dispatch.c	`96.49% <0.00%> (-0.24%)`	⬇️
tsl/src/bgw_policy/job.c	`88.62% <0.00%> (-0.05%)`	⬇️
src/bgw/job.c	`93.42% <0.00%> (+0.28%)`	⬆️
src/bgw/scheduler.c	`86.43% <0.00%> (+2.65%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a80ee...5bff287. Read the comment docs.

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill , @hongquani, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill , @hongquani, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

svenklemm requested a review from a team as a code owner July 20, 2022 17:47

svenklemm requested review from konskov and gayyappan and removed request for a team July 20, 2022 17:47

svenklemm self-assigned this Jul 20, 2022

Fix memory leak in function telemetry

5bff287

hash_create will create the hash table in TopMemoryContext unless explicitly requested to create in different memory context. The function telemetry code did not explicitly request a different context leading to a memory leak.

svenklemm force-pushed the telemetry_leak branch from 3c8b663 to 5bff287 Compare July 20, 2022 18:01

svenklemm requested review from akuzm, fabriziomello, jnidzwetzki, mfundul, nikkhils and RafiaSabih July 20, 2022 18:04

RafiaSabih approved these changes Jul 20, 2022

View reviewed changes

fabriziomello approved these changes Jul 20, 2022

View reviewed changes

mkindahl added this to the TimescaleDB 2.7.2 milestone Jul 20, 2022

fabriziomello merged commit 47d6a22 into timescale:main Jul 20, 2022

svenklemm mentioned this pull request Jul 21, 2022

Use explicit memory context with hash_create #4534

Merged

svenklemm mentioned this pull request Jul 22, 2022

Release 2.7.2 #4535

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix memory leak in function telemetry #4532

Fix memory leak in function telemetry #4532

svenklemm commented Jul 20, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

Fix memory leak in function telemetry #4532

Fix memory leak in function telemetry #4532

Conversation

svenklemm commented Jul 20, 2022 • edited Loading

codecov bot commented Jul 20, 2022 • edited Loading

Codecov Report

svenklemm commented Jul 20, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading